third_party/WebKit/Source/core/html/HTMLMediaElement.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMarqueeElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLMetaElement-in.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

index 5a63b92a411057bd6934052df59836e6eadb1078..0db0a79815eddcde4777207adab6185783338198 100644

--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

@@ -595,7 +595,7 @@ Node::InsertionNotificationRequest HTMLMediaElement::insertedInto(ContainerNode*

MEDIA_LOG << "insertedInto(" << (void*)this << ", " << insertionPoint << ")";

HTMLElement::insertedInto(insertionPoint);

- if (insertionPoint->inShadowIncludingDocument()) {

+ if (insertionPoint->isConnected()) {

UseCounter::count(document(), UseCounter::HTMLMediaElementInDocument);

if ((!getAttribute(srcAttr).isEmpty() || m_srcObject) && m_networkState == NETWORK_EMPTY) {

m_ignorePreloadNone = false;

@@ -3504,13 +3504,13 @@ void HTMLMediaElement::ensureMediaControls()

assertShadowRootChildren(shadowRoot);

- if (!shouldShowControls() || !inShadowIncludingDocument())

+ if (!shouldShowControls() || !isConnected())

mediaControls->hide();

}

void HTMLMediaElement::configureMediaControls()

{

- if (!inShadowIncludingDocument()) {

+ if (!isConnected()) {

if (mediaControls())

mediaControls()->hide();

return;