third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp ('k') | third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp

diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp b/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp

index 0bf84818a29f1e8664e767cf0fb1a97ca0e5b6e3..57e4efe498c3a91415a268638598be5ad317d14a 100644

--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp

+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp

@@ -52,9 +52,9 @@ SpellCheckRequest::SpellCheckRequest(

, m_requestNumber(requestNumber)

{

DCHECK(m_checkingRange);

- DCHECK(m_checkingRange->inShadowIncludingDocument());

+ DCHECK(m_checkingRange->isConnected());

DCHECK(m_paragraphRange);

- DCHECK(m_paragraphRange->inShadowIncludingDocument());

+ DCHECK(m_paragraphRange->isConnected());

DCHECK(m_rootEditableElement);

}

@@ -117,7 +117,7 @@ const TextCheckingRequestData& SpellCheckRequest::data() const

bool SpellCheckRequest::isValid() const

{

- return m_checkingRange->inShadowIncludingDocument() && m_paragraphRange->inShadowIncludingDocument() && m_rootEditableElement->inShadowIncludingDocument();

+ return m_checkingRange->isConnected() && m_paragraphRange->isConnected() && m_rootEditableElement->isConnected();

}

void SpellCheckRequest::didSucceed(const Vector<TextCheckingResult>& results)