third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp b/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp

index 749fa9ee041b6ddb056b637183ba0c63ab509cf3..8c6f691acaa73280127d870e1cbcd3db7327a4f5 100644

--- a/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp

@@ -256,10 +256,10 @@ void IndentOutdentCommand::outdentRegion(const VisiblePosition& startOfSelection

// outdentParagraph could move more than one paragraph if the paragraph

// is in a list item. As a result, endAfterSelection and endOfNextParagraph

// could refer to positions no longer in the document.

- if (endAfterSelection.isNotNull() && !endAfterSelection.deepEquivalent().inShadowIncludingDocument())

+ if (endAfterSelection.isNotNull() && !endAfterSelection.deepEquivalent().isConnected())

break;

- if (endOfNextParagraph.isNotNull() && !endOfNextParagraph.deepEquivalent().inShadowIncludingDocument()) {

+ if (endOfNextParagraph.isNotNull() && !endOfNextParagraph.deepEquivalent().isConnected()) {

endOfCurrentParagraph = createVisiblePosition(endingSelection().end());

endOfNextParagraph = endOfParagraph(nextPositionOf(endOfCurrentParagraph));

}