third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversal.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversal.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/custom/V0CustomElementCallbackInvocation.cpp ('k') | third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversal.cpp

diff --git a/third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversal.cpp b/third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversal.cpp

index fea0857024500eb67076f4e8d4e1b47a87135ea9..06b2b29cee3bbf52179c973a42b3182b1a85eba4 100644

--- a/third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversal.cpp

+++ b/third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversal.cpp

@@ -279,7 +279,7 @@ bool FlatTreeTraversal::isDescendantOf(const Node& node, const Node& other)

{

assertPrecondition(node);

assertPrecondition(other);

- if (!hasChildren(other) || node.inShadowIncludingDocument() != other.inShadowIncludingDocument())

+ if (!hasChildren(other) || node.isConnected() != other.isConnected())

return false;

for (const ContainerNode* n = traverseParent(node); n; n = traverseParent(*n)) {

if (n == other)