third_party/WebKit/Source/core/editing/VisiblePosition.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisiblePosition.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp ('k') | third_party/WebKit/Source/core/editing/VisibleSelection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/VisiblePosition.cpp

diff --git a/third_party/WebKit/Source/core/editing/VisiblePosition.cpp b/third_party/WebKit/Source/core/editing/VisiblePosition.cpp

index b8d19cdab35a8f75e0ca6e4d4b65c8ef9507fd9e..382c5f8ee814d0328e7f6a8ea2141cdbd67645fa 100644

--- a/third_party/WebKit/Source/core/editing/VisiblePosition.cpp

+++ b/third_party/WebKit/Source/core/editing/VisiblePosition.cpp

@@ -59,7 +59,7 @@ VisiblePositionTemplate<Strategy> VisiblePositionTemplate<Strategy>::create(cons

{

if (positionWithAffinity.isNull())

return VisiblePositionTemplate<Strategy>();

- DCHECK(positionWithAffinity.position().inShadowIncludingDocument()) << positionWithAffinity;

+ DCHECK(positionWithAffinity.position().isConnected()) << positionWithAffinity;

const PositionTemplate<Strategy> deepPosition = canonicalPositionOf(positionWithAffinity.position());

if (deepPosition.isNull())

return VisiblePositionTemplate<Strategy>();