Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/Node.idl ('k') | third_party/WebKit/Source/core/dom/Range.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp
diff --git a/third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp b/third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp
index d01f19af9d0768bb8f849df069edebc101763f52..b8f33e62498be452c35bc374969c7b8e3b244ed1 100644
--- a/third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp
+++ b/third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp
@@ -193,7 +193,7 @@ bool ProcessingInstruction::sheetLoaded()
void ProcessingInstruction::setCSSStyleSheet(const String& href, const KURL& baseURL, const String& charset, const CSSStyleSheetResource* sheet)
{
- if (!inShadowIncludingDocument()) {
+ if (!isConnected()) {
DCHECK(!m_sheet);
return;
}
@@ -220,7 +220,7 @@ void ProcessingInstruction::setCSSStyleSheet(const String& href, const KURL& bas
void ProcessingInstruction::setXSLStyleSheet(const String& href, const KURL& baseURL, const String& sheet)
{
- if (!inShadowIncludingDocument()) {
+ if (!isConnected()) {
DCHECK(!m_sheet);
return;
}
@@ -250,7 +250,7 @@ void ProcessingInstruction::parseStyleSheet(const String& sheet)
Node::InsertionNotificationRequest ProcessingInstruction::insertedInto(ContainerNode* insertionPoint)
{
CharacterData::insertedInto(insertionPoint);
- if (!insertionPoint->inShadowIncludingDocument())
+ if (!insertionPoint->isConnected())
return InsertionDone;
String href;
@@ -266,7 +266,7 @@ Node::InsertionNotificationRequest ProcessingInstruction::insertedInto(Container
void ProcessingInstruction::removedFrom(ContainerNode* insertionPoint)
{
CharacterData::removedFrom(insertionPoint);
- if (!insertionPoint->inShadowIncludingDocument())
+ if (!insertionPoint->isConnected())
return;
// No need to remove XSLStyleSheet from StyleEngine.
« no previous file with comments | « third_party/WebKit/Source/core/dom/Node.idl ('k') | third_party/WebKit/Source/core/dom/Range.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698