Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: third_party/WebKit/Source/core/svg/SVGTitleElement.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGTitleElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGTitleElement.cpp b/third_party/WebKit/Source/core/svg/SVGTitleElement.cpp
index f825bd4f2962ec716f6e107142f0e488931940ff..a54e2874c68600f22f6b3ba9109d9014208eb195 100644
--- a/third_party/WebKit/Source/core/svg/SVGTitleElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGTitleElement.cpp
@@ -38,7 +38,7 @@ DEFINE_NODE_FACTORY(SVGTitleElement)
Node::InsertionNotificationRequest SVGTitleElement::insertedInto(ContainerNode* rootParent)
{
SVGElement::insertedInto(rootParent);
- if (!rootParent->inShadowIncludingDocument())
+ if (!rootParent->isConnected())
return InsertionDone;
if (hasChildren() && document().isSVGDocument())
document().setTitleElement(this);
@@ -48,14 +48,14 @@ Node::InsertionNotificationRequest SVGTitleElement::insertedInto(ContainerNode*
void SVGTitleElement::removedFrom(ContainerNode* rootParent)
{
SVGElement::removedFrom(rootParent);
- if (rootParent->inShadowIncludingDocument() && document().isSVGDocument())
+ if (rootParent->isConnected() && document().isSVGDocument())
document().removeTitle(this);
}
void SVGTitleElement::childrenChanged(const ChildrenChange& change)
{
SVGElement::childrenChanged(change);
- if (inShadowIncludingDocument() && document().isSVGDocument() && !m_ignoreTitleUpdatesWhenChildrenChange)
+ if (isConnected() && document().isSVGDocument() && !m_ignoreTitleUpdatesWhenChildrenChange)
document().setTitleElement(this);
}
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGUseElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698