third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp b/third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp

index 0f04a788ad70dc6626edfb5c5f3269f5a3ad53da..6dd0b9a1b6693fa3a30f0de0e6f702e785d959c3 100644

--- a/third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp

@@ -196,7 +196,7 @@ void HTMLFrameSetElement::defaultEventHandler(Event* evt)

Node::InsertionNotificationRequest HTMLFrameSetElement::insertedInto(ContainerNode* insertionPoint)

{

- if (insertionPoint->inShadowIncludingDocument() && document().frame()) {

+ if (insertionPoint->isConnected() && document().frame()) {

// A document using <frameset> likely won't literally have a body, but as far as the client is concerned, the frameset is effectively the body.

document().willInsertBody();

}