Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Apple Inc. All rights reserved. 2 * Copyright (C) 2006 Apple Inc. All rights reserved.
3 * Copyright (C) 2006 Nikolas Zimmermann <zimmermann@kde.org> 3 * Copyright (C) 2006 Nikolas Zimmermann <zimmermann@kde.org>
4 * Copyright (C) 2007 Rob Buis <buis@kde.org> 4 * Copyright (C) 2007 Rob Buis <buis@kde.org>
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 150
151 void SVGDocumentExtensions::reportError(const String& message) 151 void SVGDocumentExtensions::reportError(const String& message)
152 { 152 {
153 ConsoleMessage* consoleMessage = ConsoleMessage::create(RenderingMessageSour ce, ErrorMessageLevel, "Error: " + message); 153 ConsoleMessage* consoleMessage = ConsoleMessage::create(RenderingMessageSour ce, ErrorMessageLevel, "Error: " + message);
154 m_document->addConsoleMessage(consoleMessage); 154 m_document->addConsoleMessage(consoleMessage);
155 } 155 }
156 156
157 void SVGDocumentExtensions::addPendingResource(const AtomicString& id, Element* element) 157 void SVGDocumentExtensions::addPendingResource(const AtomicString& id, Element* element)
158 { 158 {
159 ASSERT(element); 159 ASSERT(element);
160 ASSERT(element->inShadowIncludingDocument()); 160 ASSERT(element->isConnected());
161 161
162 if (id.isEmpty()) 162 if (id.isEmpty())
163 return; 163 return;
164 164
165 HeapHashMap<AtomicString, Member<SVGPendingElements>>::AddResult result = m_ pendingResources.add(id, nullptr); 165 HeapHashMap<AtomicString, Member<SVGPendingElements>>::AddResult result = m_ pendingResources.add(id, nullptr);
166 if (result.isNewEntry) 166 if (result.isNewEntry)
167 result.storedValue->value = new SVGPendingElements; 167 result.storedValue->value = new SVGPendingElements;
168 result.storedValue->value->add(element); 168 result.storedValue->value->add(element);
169 169
170 element->setHasPendingResources(); 170 element->setHasPendingResources();
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
361 { 361 {
362 visitor->trace(m_document); 362 visitor->trace(m_document);
363 visitor->trace(m_timeContainers); 363 visitor->trace(m_timeContainers);
364 visitor->trace(m_webAnimationsPendingSVGElements); 364 visitor->trace(m_webAnimationsPendingSVGElements);
365 visitor->trace(m_relativeLengthSVGRoots); 365 visitor->trace(m_relativeLengthSVGRoots);
366 visitor->trace(m_pendingResources); 366 visitor->trace(m_pendingResources);
367 visitor->trace(m_pendingResourcesForRemoval); 367 visitor->trace(m_pendingResourcesForRemoval);
368 } 368 }
369 369
370 } // namespace blink 370 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698