RefCounted types should not have public destructors, chrome/browser/extensions

RefCounted types should not have public destructors, chrome/browser/extensions version

BUG=123295
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134370

[Ryan Sleevi, 2012-04-13 09:04:40]

aa: PTAL

[Ryan Sleevi, 2012-04-25 03:35:42]

Aaron: Ping?

Note that based on the chromium-dev thread where this change was proposed, it
also minimally ensures

public -> protected -> private ordering declarations (hence the
DECLARE_EXTENSION_API_NAME shuffling), as per
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Declaration_Order

Make sure that the base class for OVERRIDEs is documented (for the files I was
touching), as per http://dev.chromium.org/developers/coding-style

http://codereview.chromium.org/10071035/diff/3001/chrome/browser/extensions/a...
File chrome/browser/extensions/api/dns/dns_api.cc (right):

http://codereview.chromium.org/10071035/diff/3001/chrome/browser/extensions/a...
chrome/browser/extensions/api/dns/dns_api.cc:29: net::HostResolver*
g_host_resolver_for_testing = NULL;
One less publicly exposed static. This was an opportunistic clean-up, but this
was one of the only places I saw statics being publicly exposed as class
members.

[Aaron Boodman, 2012-04-27 03:52:04]

lgtm

http://codereview.chromium.org/10071035/diff/3001/chrome/browser/extensions/a...
File chrome/browser/extensions/api/dns/dns_api.cc (right):

http://codereview.chromium.org/10071035/diff/3001/chrome/browser/extensions/a...
chrome/browser/extensions/api/dns/dns_api.cc:29: net::HostResolver*
g_host_resolver_for_testing = NULL;
On 2012/04/25 03:35:42, Ryan Sleevi wrote:
> One less publicly exposed static. This was an opportunistic clean-up, but this
> was one of the only places I saw statics being publicly exposed as class
> members.

It wasn't "publicly exposed" was it? Its access modifier was private, it was
just a member. I prefer your change, but I'm just curious if there's more to it
than style.

[Ryan Sleevi, 2012-04-27 03:59:30]

On 2012/04/27 03:52:04, Aaron Boodman wrote:
> lgtm
> 
>
http://codereview.chromium.org/10071035/diff/3001/chrome/browser/extensions/a...
> File chrome/browser/extensions/api/dns/dns_api.cc (right):
> 
>
http://codereview.chromium.org/10071035/diff/3001/chrome/browser/extensions/a...
> chrome/browser/extensions/api/dns/dns_api.cc:29: net::HostResolver*
> g_host_resolver_for_testing = NULL;
> On 2012/04/25 03:35:42, Ryan Sleevi wrote:
> > One less publicly exposed static. This was an opportunistic clean-up, but
this
> > was one of the only places I saw statics being publicly exposed as class
> > members.
> 
> It wasn't "publicly exposed" was it? Its access modifier was private, it was
> just a member. I prefer your change, but I'm just curious if there's more to
it
> than style.

Sorry, publicly exposed in the sense of "implementation detail in the header".
The access specifier is indeed private, but now it's hidden entirely in the
implementation file.

So yeah, just style :)

[commit-bot: I haz the power, 2012-04-27 04:59:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10071035/11004

[commit-bot: I haz the power, 2012-04-27 05:19:14]

Try job failure for 10071035-11004 (retry) on mac_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-04-27 05:50:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10071035/21001

[commit-bot: I haz the power, 2012-04-27 06:10:06]

Try job failure for 10071035-21001 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-04-27 20:03:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10071035/26003

[commit-bot: I haz the power, 2012-04-27 22:19:02]

Change committed as 134370