Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: chrome/browser/extensions/api/extension_action/extension_browser_actions_api.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/extension_action/extension_browser_actions_api.h
diff --git a/chrome/browser/extensions/api/extension_action/extension_browser_actions_api.h b/chrome/browser/extensions/api/extension_action/extension_browser_actions_api.h
index ed5ddf7d738f4a46ee69db0f8054d90a000c34d6..0b0de5f64bcaf79f8cbcef36672e9eaf5b81ba87 100644
--- a/chrome/browser/extensions/api/extension_action/extension_browser_actions_api.h
+++ b/chrome/browser/extensions/api/extension_action/extension_browser_actions_api.h
@@ -15,52 +15,79 @@
//
class BrowserActionSetIconFunction : public ExtensionActionSetIconFunction {
- virtual ~BrowserActionSetIconFunction() {}
+ public:
DECLARE_EXTENSION_FUNCTION_NAME("browserAction.setIcon")
+
+ protected:
+ virtual ~BrowserActionSetIconFunction() {}
};
class BrowserActionSetTitleFunction : public ExtensionActionSetTitleFunction {
- virtual ~BrowserActionSetTitleFunction() {}
+ public:
DECLARE_EXTENSION_FUNCTION_NAME("browserAction.setTitle")
+
+ protected:
+ virtual ~BrowserActionSetTitleFunction() {}
};
class BrowserActionSetPopupFunction : public ExtensionActionSetPopupFunction {
- virtual ~BrowserActionSetPopupFunction() {}
+ public:
DECLARE_EXTENSION_FUNCTION_NAME("browserAction.setPopup")
+
+ protected:
+ virtual ~BrowserActionSetPopupFunction() {}
};
class BrowserActionGetTitleFunction : public ExtensionActionGetTitleFunction {
- virtual ~BrowserActionGetTitleFunction() {}
+ public:
DECLARE_EXTENSION_FUNCTION_NAME("browserAction.getTitle")
+
+ protected:
+ virtual ~BrowserActionGetTitleFunction() {}
};
class BrowserActionGetPopupFunction : public ExtensionActionGetPopupFunction {
- virtual ~BrowserActionGetPopupFunction() {}
+ public:
DECLARE_EXTENSION_FUNCTION_NAME("browserAction.getPopup")
+
+ protected:
+ virtual ~BrowserActionGetPopupFunction() {}
};
class BrowserActionSetBadgeTextFunction
: public ExtensionActionSetBadgeTextFunction {
- virtual ~BrowserActionSetBadgeTextFunction() {}
+ public:
DECLARE_EXTENSION_FUNCTION_NAME("browserAction.setBadgeText")
+
+ protected:
+ virtual ~BrowserActionSetBadgeTextFunction() {}
};
class BrowserActionSetBadgeBackgroundColorFunction
: public ExtensionActionSetBadgeBackgroundColorFunction {
- virtual ~BrowserActionSetBadgeBackgroundColorFunction() {}
+ public:
DECLARE_EXTENSION_FUNCTION_NAME("browserAction.setBadgeBackgroundColor")
+
+ protected:
+ virtual ~BrowserActionSetBadgeBackgroundColorFunction() {}
};
class BrowserActionGetBadgeTextFunction
: public ExtensionActionGetBadgeTextFunction {
- virtual ~BrowserActionGetBadgeTextFunction() {}
+ public:
DECLARE_EXTENSION_FUNCTION_NAME("browserAction.getBadgeText")
+
+ protected:
+ virtual ~BrowserActionGetBadgeTextFunction() {}
};
class BrowserActionGetBadgeBackgroundColorFunction
: public ExtensionActionGetBadgeBackgroundColorFunction {
- virtual ~BrowserActionGetBadgeBackgroundColorFunction() {}
+ public:
DECLARE_EXTENSION_FUNCTION_NAME("browserAction.getBadgeBackgroundColor")
+
+ protected:
+ virtual ~BrowserActionGetBadgeBackgroundColorFunction() {}
};
#endif // CHROME_BROWSER_EXTENSIONS_API_EXTENSION_ACTION_EXTENSION_BROWSER_ACTIONS_API_H_

Powered by Google App Engine
This is Rietveld 408576698