RefCounted types should not have public destructors, chrome/browser/extensions

chrome/browser/extensions/extension_font_settings_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_FONT_SETTINGS_API_H__
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_FONT_SETTINGS_API_H__
 #pragma once
 
 #include <map>
 
@@ skipping 40 matching lines @@
   PrefEventMap pref_event_map_;
 
   // Weak, owns us (transitively via ExtensionService).
   Profile* profile_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionFontSettingsEventRouter);
 };
 
 class ClearFontFunction : public SyncExtensionFunction {
  public:
+  DECLARE_EXTENSION_FUNCTION_NAME("experimental.fontSettings.clearFont")
+
+ protected:
+  virtual ~ClearFontFunction() {}
+
+  // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
-  DECLARE_EXTENSION_FUNCTION_NAME("experimental.fontSettings.clearFont")
 };
 
 class GetFontFunction : public SyncExtensionFunction {
  public:
+  DECLARE_EXTENSION_FUNCTION_NAME("experimental.fontSettings.getFont")
+
+ protected:
+  virtual ~GetFontFunction() {}
+
+  // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
-  DECLARE_EXTENSION_FUNCTION_NAME("experimental.fontSettings.getFont")
 };
 
 class SetFontFunction : public SyncExtensionFunction {
  public:
+  DECLARE_EXTENSION_FUNCTION_NAME("experimental.fontSettings.setFont")
+
+ protected:
+  virtual ~SetFontFunction() {}
+
+  // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
-  DECLARE_EXTENSION_FUNCTION_NAME("experimental.fontSettings.setFont")
 };
 
 class GetFontListFunction : public AsyncExtensionFunction {
  public:
+  DECLARE_EXTENSION_FUNCTION_NAME("experimental.fontSettings.getFontList")
+
+ protected:
+  virtual ~GetFontListFunction() {}
+
+  // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
-  DECLARE_EXTENSION_FUNCTION_NAME("experimental.fontSettings.getFontList")
 
  private:
   void FontListHasLoaded(scoped_ptr<base::ListValue> list);
   bool CopyFontsToResult(base::ListValue* fonts);
 };
 
 // Base class for functions that clear a font pref.
 class ClearFontPrefExtensionFunction : public SyncExtensionFunction {
  protected:
+  virtual ~ClearFontPrefExtensionFunction() {}
+
+  // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
 
   // Implementations should return the name of the preference to clear, like
   // "webkit.webprefs.default_font_size".
   virtual const char* GetPrefName() = 0;
 };
 
 // Base class for functions that get a font pref.
 class GetFontPrefExtensionFunction : public SyncExtensionFunction {
  protected:
+  virtual ~GetFontPrefExtensionFunction() {}
+
+  // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
 
   // Implementations should return the name of the preference to get, like
   // "webkit.webprefs.default_font_size".
   virtual const char* GetPrefName() = 0;
 
   // Implementations should return the key for the value in the extension API,
   // like "pixelSize".
   virtual const char* GetKey() = 0;
 };
 
 // Base class for functions that set a font pref.
 class SetFontPrefExtensionFunction : public SyncExtensionFunction {
  protected:
+  virtual ~SetFontPrefExtensionFunction() {}
+
+  // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
 
   // Implementations should return the name of the preference to set, like
   // "webkit.webprefs.default_font_size".
   virtual const char* GetPrefName() = 0;
 
   // Implementations should return the key for the value in the extension API,
   // like "pixelSize".
   virtual const char* GetKey() = 0;
 };
 
 class ClearDefaultFontSizeFunction : public ClearFontPrefExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME(
       "experimental.fontSettings.clearDefaultFontSize")
 
  protected:
+  virtual ~ClearDefaultFontSizeFunction() {}
+
+  // ClearFontPrefExtensionFunction:
   virtual const char* GetPrefName() OVERRIDE;
 };
 
 class GetDefaultFontSizeFunction : public GetFontPrefExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME(
       "experimental.fontSettings.getDefaultFontSize")
 
  protected:
+  virtual ~GetDefaultFontSizeFunction() {}
+
+  // GetFontPrefExtensionFunction:
   virtual const char* GetPrefName() OVERRIDE;
   virtual const char* GetKey() OVERRIDE;
 };
 
 class SetDefaultFontSizeFunction : public SetFontPrefExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME(
       "experimental.fontSettings.setDefaultFontSize")
 
  protected:
+  virtual ~SetDefaultFontSizeFunction() {}
+
+  // SetFontPrefExtensionFunction:
   virtual const char* GetPrefName() OVERRIDE;
   virtual const char* GetKey() OVERRIDE;
 };
 
 class ClearDefaultFixedFontSizeFunction
     : public ClearFontPrefExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME(
       "experimental.fontSettings.clearDefaultFixedFontSize")
 
  protected:
+  virtual ~ClearDefaultFixedFontSizeFunction() {}
+
+  // ClearFontPrefExtensionFunction:
   virtual const char* GetPrefName() OVERRIDE;
 };
 
 class GetDefaultFixedFontSizeFunction : public GetFontPrefExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME(
       "experimental.fontSettings.getDefaultFixedFontSize")
 
  protected:
+  virtual ~GetDefaultFixedFontSizeFunction() {}
+
+  // GetFontPrefExtensionFunction:
   virtual const char* GetPrefName() OVERRIDE;
   virtual const char* GetKey() OVERRIDE;
 };
 
 class SetDefaultFixedFontSizeFunction : public SetFontPrefExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME(
       "experimental.fontSettings.setDefaultFixedFontSize")
 
  protected:
+  virtual ~SetDefaultFixedFontSizeFunction() {}
+
+  // SetFontPrefExtensionFunction:
   virtual const char* GetPrefName() OVERRIDE;
   virtual const char* GetKey() OVERRIDE;
 };
 
 class ClearMinimumFontSizeFunction : public ClearFontPrefExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME(
       "experimental.fontSettings.clearMinimumFontSize")
 
  protected:
+  virtual ~ClearMinimumFontSizeFunction() {}
+
+  // ClearFontPrefExtensionFunction:
   virtual const char* GetPrefName() OVERRIDE;
 };
 
 class GetMinimumFontSizeFunction : public GetFontPrefExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME(
       "experimental.fontSettings.getMinimumFontSize")
 
  protected:
+  virtual ~GetMinimumFontSizeFunction() {}
+
+  // GetFontPrefExtensionFunction:
   virtual const char* GetPrefName() OVERRIDE;
   virtual const char* GetKey() OVERRIDE;
 };
 
 class SetMinimumFontSizeFunction : public SetFontPrefExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME(
       "experimental.fontSettings.setMinimumFontSize")
 
  protected:
+  virtual ~SetMinimumFontSizeFunction() {}
+
+  // SetFontPrefExtensionFunction:
   virtual const char* GetPrefName() OVERRIDE;
   virtual const char* GetKey() OVERRIDE;
 };
 
 class ClearDefaultCharacterSetFunction : public ClearFontPrefExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME(
       "experimental.fontSettings.clearDefaultCharacterSet")
 
  protected:
+  virtual ~ClearDefaultCharacterSetFunction() {}
+
+  // ClearFontPrefExtensionFunction:
   virtual const char* GetPrefName() OVERRIDE;
 };
 
 class GetDefaultCharacterSetFunction : public GetFontPrefExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME(
       "experimental.fontSettings.getDefaultCharacterSet")
 
  protected:
+  virtual ~GetDefaultCharacterSetFunction() {}
+
+  // GetFontPrefExtensionFunction:
   virtual const char* GetPrefName() OVERRIDE;
   virtual const char* GetKey() OVERRIDE;
 };
 
 class SetDefaultCharacterSetFunction : public SetFontPrefExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME(
       "experimental.fontSettings.setDefaultCharacterSet")
 
  protected:
+  virtual ~SetDefaultCharacterSetFunction() {}
+
+  // SetFontPrefExtensionFunction:
   virtual const char* GetPrefName() OVERRIDE;
   virtual const char* GetKey() OVERRIDE;
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_FONT_SETTINGS_API_H__