Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7133)

Unified Diff: chrome/browser/extensions/api/extension_action/extension_page_actions_api.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/extension_action/extension_page_actions_api.h
diff --git a/chrome/browser/extensions/api/extension_action/extension_page_actions_api.h b/chrome/browser/extensions/api/extension_action/extension_page_actions_api.h
index d75380d074abfcdacee470ce3aef3d2651cacbbd..696fd449205b91895f3fe0d96f04a04363ac8a42 100644
--- a/chrome/browser/extensions/api/extension_action/extension_page_actions_api.h
+++ b/chrome/browser/extensions/api/extension_action/extension_page_actions_api.h
@@ -19,16 +19,26 @@ class PageActionsFunction : public SyncExtensionFunction {
// Implement chrome.pageActions.enableForTab().
class EnablePageActionsFunction : public PageActionsFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("pageActions.enableForTab")
+
+ protected:
virtual ~EnablePageActionsFunction() {}
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("pageActions.enableForTab")
};
// Implement chrome.pageActions.disableForTab().
class DisablePageActionsFunction : public PageActionsFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("pageActions.disableForTab")
+
+ protected:
virtual ~DisablePageActionsFunction() {}
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("pageActions.disableForTab")
};
//
@@ -36,38 +46,59 @@ class DisablePageActionsFunction : public PageActionsFunction {
//
class PageActionShowFunction : public ExtensionActionShowFunction {
- virtual ~PageActionShowFunction() {}
+ public:
DECLARE_EXTENSION_FUNCTION_NAME("pageAction.show")
+
+ protected:
+ virtual ~PageActionShowFunction() {}
};
class PageActionHideFunction : public ExtensionActionHideFunction {
- virtual ~PageActionHideFunction() {}
+ public:
DECLARE_EXTENSION_FUNCTION_NAME("pageAction.hide")
+
+ protected:
+ virtual ~PageActionHideFunction() {}
};
class PageActionSetIconFunction : public ExtensionActionSetIconFunction {
- virtual ~PageActionSetIconFunction() {}
+ public:
DECLARE_EXTENSION_FUNCTION_NAME("pageAction.setIcon")
+
+ protected:
+ virtual ~PageActionSetIconFunction() {}
};
class PageActionSetTitleFunction : public ExtensionActionSetTitleFunction {
- virtual ~PageActionSetTitleFunction() {}
+ public:
DECLARE_EXTENSION_FUNCTION_NAME("pageAction.setTitle")
+
+ protected:
+ virtual ~PageActionSetTitleFunction() {}
};
class PageActionSetPopupFunction : public ExtensionActionSetPopupFunction {
- virtual ~PageActionSetPopupFunction() {}
+ public:
DECLARE_EXTENSION_FUNCTION_NAME("pageAction.setPopup")
+
+ protected:
+ virtual ~PageActionSetPopupFunction() {}
};
class PageActionGetTitleFunction : public ExtensionActionGetTitleFunction {
- virtual ~PageActionGetTitleFunction() {}
+ public:
DECLARE_EXTENSION_FUNCTION_NAME("pageAction.getTitle")
+
+ protected:
+ virtual ~PageActionGetTitleFunction() {}
};
class PageActionGetPopupFunction : public ExtensionActionGetPopupFunction {
- virtual ~PageActionGetPopupFunction() {}
+ public:
DECLARE_EXTENSION_FUNCTION_NAME("pageAction.getPopup")
+
+ protected:
+ virtual ~PageActionGetPopupFunction() {}
};
#endif // CHROME_BROWSER_EXTENSIONS_API_EXTENSION_ACTION_EXTENSION_PAGE_ACTIONS_API_H_

Powered by Google App Engine
This is Rietveld 408576698