Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3815)

Unified Diff: chrome/browser/extensions/api/declarative/test_rules_registry.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/declarative/test_rules_registry.h
diff --git a/chrome/browser/extensions/api/declarative/test_rules_registry.h b/chrome/browser/extensions/api/declarative/test_rules_registry.h
index 7c18891c10a222968d38d6e1a775b98093f1e6e4..151f8ee2eacc6418ba86d3f56fdd692fbf763b29 100644
--- a/chrome/browser/extensions/api/declarative/test_rules_registry.h
+++ b/chrome/browser/extensions/api/declarative/test_rules_registry.h
@@ -14,12 +14,10 @@ namespace extensions {
class TestRulesRegistry : public RulesRegistryWithCache {
public:
TestRulesRegistry();
- virtual ~TestRulesRegistry();
void SetOwnerThread(content::BrowserThread::ID owner_thread);
// RulesRegistryWithCache implementation:
- virtual content::BrowserThread::ID GetOwnerThread() const OVERRIDE;
virtual std::string AddRulesImpl(
const std::string& extension_id,
const std::vector<linked_ptr<RulesRegistry::Rule> >& rules) OVERRIDE;
@@ -28,11 +26,15 @@ class TestRulesRegistry : public RulesRegistryWithCache {
const std::vector<std::string>& rule_identifiers) OVERRIDE;
virtual std::string RemoveAllRulesImpl(
const std::string& extension_id) OVERRIDE;
+ virtual content::BrowserThread::ID GetOwnerThread() const OVERRIDE;
// Sets the result message that will be returned by the next call of
// AddRulesImpl, RemoveRulesImpl and RemoveAllRulesImpl.
void SetResult(const std::string& result);
+ protected:
+ virtual ~TestRulesRegistry();
+
private:
// The string that gets returned by the implementation functions of
// RulesRegistryWithCache. Defaults to "".

Powered by Google App Engine
This is Rietveld 408576698