Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: chrome/browser/extensions/app_notification_manager.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/app_notification_manager.h
diff --git a/chrome/browser/extensions/app_notification_manager.h b/chrome/browser/extensions/app_notification_manager.h
index 44bdd9bf0ae1d9120d083d9da8fcc2196383fec9..90b92535781826e4cc1e6ceec9d65471aef4b82b 100644
--- a/chrome/browser/extensions/app_notification_manager.h
+++ b/chrome/browser/extensions/app_notification_manager.h
@@ -12,6 +12,7 @@
#include "base/gtest_prod_util.h"
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
+#include "base/sequenced_task_runner_helpers.h"
#include "base/synchronization/waitable_event.h"
#include "chrome/browser/extensions/app_notification.h"
#include "chrome/browser/extensions/app_notification_storage.h"
@@ -36,7 +37,6 @@ class AppNotificationManager
public:
static const unsigned int kMaxNotificationPerApp;
explicit AppNotificationManager(Profile* profile);
- virtual ~AppNotificationManager();
// Starts up the process of reading from persistent storage.
void Init();
@@ -80,6 +80,9 @@ class AppNotificationManager
private:
friend class AppNotificationManagerSyncTest;
+ friend class base::DeleteHelper<AppNotificationManager>;
+ friend struct content::BrowserThread::DeleteOnThread<
+ content::BrowserThread::UI>;
FRIEND_TEST_ALL_PREFIXES(AppNotificationManagerSyncTest,
NotificationToSyncDataToNotification);
FRIEND_TEST_ALL_PREFIXES(AppNotificationManagerSyncTest,
@@ -105,11 +108,11 @@ class AppNotificationManager
FRIEND_TEST_ALL_PREFIXES(AppNotificationManagerSyncTest,
ClearAllGetsSynced);
- friend class base::RefCountedThreadSafe<AppNotificationManager>;
-
// Maps extension id to a list of notifications for that extension.
typedef std::map<std::string, AppNotificationList> NotificationMap;
+ virtual ~AppNotificationManager();
+
// Starts loading storage_ using |storage_path|.
void LoadOnFileThread(const FilePath& storage_path);

Powered by Google App Engine
This is Rietveld 408576698