chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc - Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Compile fix Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative/rules_registry_with_cache.h ('k') | chrome/browser/extensions/api/declarative/test_rules_registry.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc

diff --git a/chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc b/chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc

index 1234b9f3db2231ce4e1dc86c04ec26d2bf2055a8..49bb9ea5952e1d2fe6f1cc5053bd5254400e8573 100644

--- a/chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc

+++ b/chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc

@@ -18,8 +18,6 @@ namespace extensions {

RulesRegistryWithCache::RulesRegistryWithCache() {}

-RulesRegistryWithCache::~RulesRegistryWithCache() {}

std::string RulesRegistryWithCache::AddRules(

const std::string& extension_id,

const std::vector<linked_ptr<Rule> >& rules) {

@@ -126,4 +124,6 @@ void RulesRegistryWithCache::OnExtensionUnloaded(

LOG(ERROR) << error;

}

+RulesRegistryWithCache::~RulesRegistryWithCache() {}

} // namespace extensions