Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: chrome/browser/extensions/extension_debugger_api.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_debugger_api.h
diff --git a/chrome/browser/extensions/extension_debugger_api.h b/chrome/browser/extensions/extension_debugger_api.h
index 3943bf16779fc42ffaee4e0060d2d5595cc7d18a..82d4392ec117fef9e2588217796aab2ff0690565 100644
--- a/chrome/browser/extensions/extension_debugger_api.h
+++ b/chrome/browser/extensions/extension_debugger_api.h
@@ -41,30 +41,44 @@ class DebuggerFunction : public AsyncExtensionFunction {
// Implements the debugger.attach() extension function.
class AttachDebuggerFunction : public DebuggerFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("debugger.attach")
+
AttachDebuggerFunction();
+
+ protected:
virtual ~AttachDebuggerFunction();
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("debugger.attach")
};
// Implements the debugger.detach() extension function.
class DetachDebuggerFunction : public DebuggerFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("debugger.detach")
+
DetachDebuggerFunction();
+
+ protected:
virtual ~DetachDebuggerFunction();
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("debugger.detach")
};
// Implements the debugger.sendCommand() extension function.
class SendCommandDebuggerFunction : public DebuggerFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("debugger.sendCommand")
+
SendCommandDebuggerFunction();
+ void SendResponseBody(base::DictionaryValue* dictionary);
+
+ protected:
virtual ~SendCommandDebuggerFunction();
- virtual bool RunImpl() OVERRIDE;
- void SendResponseBody(base::DictionaryValue* dictionary);
- DECLARE_EXTENSION_FUNCTION_NAME("debugger.sendCommand")
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
#endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_DEBUGGER_API_H_

Powered by Google App Engine
This is Rietveld 408576698