Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1928)

Unified Diff: chrome/browser/extensions/api/permissions/permissions_api.cc

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/permissions/permissions_api.cc
diff --git a/chrome/browser/extensions/api/permissions/permissions_api.cc b/chrome/browser/extensions/api/permissions/permissions_api.cc
index 440050a92dbb6cea9325eaef366233e70bdbbf22..e481c2710957c5410e44ae04614c70eb4ba77f0c 100644
--- a/chrome/browser/extensions/api/permissions/permissions_api.cc
+++ b/chrome/browser/extensions/api/permissions/permissions_api.cc
@@ -117,6 +117,24 @@ void RequestPermissionsFunction::SetIgnoreUserGestureForTests(
}
RequestPermissionsFunction::RequestPermissionsFunction() {}
+
+void RequestPermissionsFunction::InstallUIProceed() {
+ PermissionsUpdater perms_updater(profile());
+ perms_updater.AddPermissions(GetExtension(), requested_permissions_.get());
+
+ result_.reset(Request::Result::Create(true));
+ SendResponse(true);
+
+ Release(); // Balanced in RunImpl().
+}
+
+void RequestPermissionsFunction::InstallUIAbort(bool user_initiated) {
+ result_.reset(Request::Result::Create(false));
+ SendResponse(true);
+
+ Release(); // Balanced in RunImpl().
+}
+
RequestPermissionsFunction::~RequestPermissionsFunction() {}
bool RequestPermissionsFunction::RunImpl() {
@@ -192,20 +210,3 @@ bool RequestPermissionsFunction::RunImpl() {
return true;
}
-
-void RequestPermissionsFunction::InstallUIProceed() {
- PermissionsUpdater perms_updater(profile());
- perms_updater.AddPermissions(GetExtension(), requested_permissions_.get());
-
- result_.reset(Request::Result::Create(true));
- SendResponse(true);
-
- Release(); // Balanced in RunImpl().
-}
-
-void RequestPermissionsFunction::InstallUIAbort(bool user_initiated) {
- result_.reset(Request::Result::Create(false));
- SendResponse(true);
-
- Release(); // Balanced in RunImpl().
-}
« no previous file with comments | « chrome/browser/extensions/api/permissions/permissions_api.h ('k') | chrome/browser/extensions/api/serial/serial_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698