Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: chrome/browser/extensions/api/api_function.cc

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/api_function.cc
diff --git a/chrome/browser/extensions/api/api_function.cc b/chrome/browser/extensions/api/api_function.cc
index bfc27911865d0b8518f96bd1e0ccc8df72e093dd..c61c82ac641a4613bdcfa67b1ffb8562525683a2 100644
--- a/chrome/browser/extensions/api/api_function.cc
+++ b/chrome/browser/extensions/api/api_function.cc
@@ -15,34 +15,6 @@ using content::BrowserThread;
namespace extensions {
-bool AsyncIOAPIFunction::RunImpl() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- extension_service_ = profile()->GetExtensionService();
-
- if (!Prepare()) {
- return false;
- }
- bool rv = BrowserThread::PostTask(
- BrowserThread::IO, FROM_HERE,
- base::Bind(&AsyncIOAPIFunction::WorkOnIOThread, this));
- DCHECK(rv);
- return true;
-}
-
-void AsyncIOAPIFunction::WorkOnIOThread() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
- Work();
- bool rv = BrowserThread::PostTask(
- BrowserThread::UI, FROM_HERE,
- base::Bind(&AsyncIOAPIFunction::RespondOnUIThread, this));
- DCHECK(rv);
-}
-
-void AsyncIOAPIFunction::RespondOnUIThread() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- SendResponse(Respond());
-}
-
int AsyncIOAPIFunction::ExtractSrcId(size_t argument_position) {
scoped_ptr<DictionaryValue> options(new DictionaryValue());
if (args_->GetSize() > argument_position) {
@@ -75,4 +47,32 @@ APIResourceController* AsyncIOAPIFunction::controller() {
return extension_service_->api_resource_controller();
}
+bool AsyncIOAPIFunction::RunImpl() {
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ extension_service_ = profile()->GetExtensionService();
+
+ if (!Prepare()) {
+ return false;
+ }
+ bool rv = BrowserThread::PostTask(
+ BrowserThread::IO, FROM_HERE,
+ base::Bind(&AsyncIOAPIFunction::WorkOnIOThread, this));
+ DCHECK(rv);
+ return true;
+}
+
+void AsyncIOAPIFunction::WorkOnIOThread() {
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ Work();
+ bool rv = BrowserThread::PostTask(
+ BrowserThread::UI, FROM_HERE,
+ base::Bind(&AsyncIOAPIFunction::RespondOnUIThread, this));
+ DCHECK(rv);
+}
+
+void AsyncIOAPIFunction::RespondOnUIThread() {
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ SendResponse(Respond());
+}
+
} // namespace extensions
« no previous file with comments | « chrome/browser/extensions/api/api_function.h ('k') | chrome/browser/extensions/api/api_resource_event_notifier.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698