RefCounted types should not have public destructors, chrome/browser/extensions

chrome/browser/extensions/api/web_request/web_request_api_helpers.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/web_request/web_request_api_helpers.h"
 
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/api/web_request/web_request_api.h"
@@ skipping 60 matching lines @@
 
 EventLogEntry::~EventLogEntry() {
 }
 
 
 // NetLog parameter to indicate the ID of the extension that caused an event.
 class NetLogExtensionIdParameter : public net::NetLog::EventParameters {
  public:
   explicit NetLogExtensionIdParameter(const std::string& extension_id)
       : extension_id_(extension_id) {}
-  virtual ~NetLogExtensionIdParameter() {}
 
   virtual base::Value* ToValue() const OVERRIDE {
     DictionaryValue* dict = new DictionaryValue();
     dict->SetString("extension_id", extension_id_);
     return dict;
   }
 
+ protected:
+  virtual ~NetLogExtensionIdParameter() {}
+
  private:
   const std::string extension_id_;
 
   DISALLOW_COPY_AND_ASSIGN(NetLogExtensionIdParameter);
 };
 
 
 // NetLog parameter to indicate that an extension modified a request.
 class NetLogModificationParameter : public NetLogExtensionIdParameter {
  public:
   explicit NetLogModificationParameter(const std::string& extension_id)
       : NetLogExtensionIdParameter(extension_id) {}
-  virtual ~NetLogModificationParameter() {}
 
   virtual base::Value* ToValue() const OVERRIDE {
     Value* parent = NetLogExtensionIdParameter::ToValue();
     DCHECK(parent->IsType(Value::TYPE_DICTIONARY));
     DictionaryValue* dict = static_cast<DictionaryValue*>(parent);
     dict->Set("modified_headers", modified_headers_.DeepCopy());
     dict->Set("deleted_headers", deleted_headers_.DeepCopy());
     return dict;
   }
 
   void DeletedHeader(const std::string& key) {
     deleted_headers_.Append(Value::CreateStringValue(key));
   }
 
   void ModifiedHeader(const std::string& key, const std::string& value) {
     modified_headers_.Append(Value::CreateStringValue(key + ": " + value));
   }
 
  private:
+  virtual ~NetLogModificationParameter() {}
+
   ListValue modified_headers_;
   ListValue deleted_headers_;
 
   DISALLOW_COPY_AND_ASSIGN(NetLogModificationParameter);
 };
 
 
 bool InDecreasingExtensionInstallationTimeOrder(
     const linked_ptr<EventResponseDelta>& a,
     const linked_ptr<EventResponseDelta>& b) {
@@ skipping 522 matching lines @@
                        ResourceType::Type* type) {
   const char** iter =
       std::find(kResourceTypeStrings, ARRAYEND(kResourceTypeStrings), type_str);
   if (iter == ARRAYEND(kResourceTypeStrings))
     return false;
   *type = kResourceTypeValues[iter - kResourceTypeStrings];
   return true;
 }
 
 }  // namespace extension_web_request_api_helpers