Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1297)

Unified Diff: chrome/browser/extensions/execute_code_in_tab_function.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/execute_code_in_tab_function.h
diff --git a/chrome/browser/extensions/execute_code_in_tab_function.h b/chrome/browser/extensions/execute_code_in_tab_function.h
index ccdee290870eb2f4b3791cf9365c53e2c91a774b..81cee16c7a4241fc4c8ad4d4501f8ca5c3b23c57 100644
--- a/chrome/browser/extensions/execute_code_in_tab_function.h
+++ b/chrome/browser/extensions/execute_code_in_tab_function.h
@@ -18,11 +18,14 @@ class ExecuteCodeInTabFunction : public AsyncExtensionFunction,
public content::WebContentsObserver {
public:
ExecuteCodeInTabFunction();
+
+ protected:
virtual ~ExecuteCodeInTabFunction();
- private:
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
+ private:
// content::WebContentsObserver overrides.
virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
@@ -65,10 +68,16 @@ class ExecuteCodeInTabFunction : public AsyncExtensionFunction,
};
class TabsExecuteScriptFunction : public ExecuteCodeInTabFunction {
+ private:
+ virtual ~TabsExecuteScriptFunction() {}
+
DECLARE_EXTENSION_FUNCTION_NAME("tabs.executeScript")
};
class TabsInsertCSSFunction : public ExecuteCodeInTabFunction {
+ private:
+ virtual ~TabsInsertCSSFunction() {}
+
DECLARE_EXTENSION_FUNCTION_NAME("tabs.insertCSS")
};
« no previous file with comments | « chrome/browser/extensions/bundle_installer.cc ('k') | chrome/browser/extensions/execute_code_in_tab_function.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698