Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6436)

Unified Diff: chrome/browser/extensions/extension_management_api.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_management_api.h
diff --git a/chrome/browser/extensions/extension_management_api.h b/chrome/browser/extensions/extension_management_api.h
index b7e6b8011c87fd051ac4d1b9131069da8ad20f18..3c307100219f92cb57111586e048799b7f42b1af 100644
--- a/chrome/browser/extensions/extension_management_api.h
+++ b/chrome/browser/extensions/extension_management_api.h
@@ -16,58 +16,91 @@ class ExtensionService;
class ExtensionManagementFunction : public SyncExtensionFunction {
protected:
+ virtual ~ExtensionManagementFunction() {}
+
ExtensionService* service();
};
class AsyncExtensionManagementFunction : public AsyncExtensionFunction {
protected:
+ virtual ~AsyncExtensionManagementFunction() {}
+
ExtensionService* service();
};
class GetAllExtensionsFunction : public ExtensionManagementFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("management.getAll");
+
+ protected:
virtual ~GetAllExtensionsFunction() {}
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("management.getAll");
};
class GetExtensionByIdFunction : public ExtensionManagementFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("management.get");
+
+ protected:
virtual ~GetExtensionByIdFunction() {}
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("management.get");
};
class GetPermissionWarningsByIdFunction : public ExtensionManagementFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("management.getPermissionWarningsById");
+
+ protected:
virtual ~GetPermissionWarningsByIdFunction() {}
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("management.getPermissionWarningsById");
};
class GetPermissionWarningsByManifestFunction : public AsyncExtensionFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME(
+ "management.getPermissionWarningsByManifest");
+
// Called when utility process finishes.
void OnParseSuccess(base::DictionaryValue* parsed_manifest);
void OnParseFailure(const std::string& error);
+
protected:
virtual ~GetPermissionWarningsByManifestFunction() {}
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME(
- "management.getPermissionWarningsByManifest");
};
class LaunchAppFunction : public ExtensionManagementFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("management.launchApp");
+
+ protected:
virtual ~LaunchAppFunction() {}
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("management.launchApp");
};
class SetEnabledFunction : public AsyncExtensionManagementFunction,
public ExtensionInstallUI::Delegate {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("management.setEnabled");
+
SetEnabledFunction();
+
+ protected:
virtual ~SetEnabledFunction();
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- protected:
// ExtensionInstalUI::Delegate.
virtual void InstallUIProceed() OVERRIDE;
virtual void InstallUIAbort(bool user_initiated) OVERRIDE;
@@ -77,14 +110,17 @@ class SetEnabledFunction : public AsyncExtensionManagementFunction,
// Used for prompting to re-enable items with permissions escalation updates.
scoped_ptr<ExtensionInstallUI> install_ui_;
-
- DECLARE_EXTENSION_FUNCTION_NAME("management.setEnabled");
};
class UninstallFunction : public ExtensionManagementFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("management.uninstall");
+
+ protected:
virtual ~UninstallFunction() {}
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("management.uninstall");
};
class ExtensionManagementEventRouter : public content::NotificationObserver {
« no previous file with comments | « chrome/browser/extensions/extension_managed_mode_api.h ('k') | chrome/browser/extensions/extension_metrics_module.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698