Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1442)

Unified Diff: chrome/browser/extensions/extension_input_api.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_input_api.h
diff --git a/chrome/browser/extensions/extension_input_api.h b/chrome/browser/extensions/extension_input_api.h
index b50436cf5344b2c3eb83723d0733222e73f0697e..dc0fe8a8cbef79d63c6ffe769ee171716ff392d9 100644
--- a/chrome/browser/extensions/extension_input_api.h
+++ b/chrome/browser/extensions/extension_input_api.h
@@ -16,24 +16,39 @@
// synthetic event distribution code to this Function.
class SendKeyboardEventInputFunction : public SyncExtensionFunction {
public:
- virtual bool RunImpl() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME(
"experimental.input.virtualKeyboard.sendKeyboardEvent");
+
+ protected:
+ virtual ~SendKeyboardEventInputFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
#if defined(USE_VIRTUAL_KEYBOARD)
class HideKeyboardFunction : public AsyncExtensionFunction {
public:
- virtual bool RunImpl() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME(
"experimental.input.virtualKeyboard.hideKeyboard");
+
+ protected:
+ virtual ~HideKeyboardFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class SetKeyboardHeightFunction : public AsyncExtensionFunction {
public:
- virtual bool RunImpl() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME(
"experimental.input.virtualKeyboard.setKeyboardHeight");
+
+ protected:
+ virtual ~SetKeyboardHeightFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
#endif
@@ -46,16 +61,22 @@ class SetKeyboardHeightFunction : public AsyncExtensionFunction {
// without USE_VIRTUAL_KEYBOARD.
class SendHandwritingStrokeFunction : public SyncExtensionFunction {
public:
- virtual bool RunImpl() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME(
"experimental.input.virtualKeyboard.sendHandwritingStroke");
+
+ protected:
+ virtual ~SendHandwritingStrokeFunction() {}
+ virtual bool RunImpl() OVERRIDE;
};
class CancelHandwritingStrokesFunction : public SyncExtensionFunction {
public:
- virtual bool RunImpl() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME(
"experimental.input.virtualKeyboard.cancelHandwritingStrokes");
+
+ public:
+ virtual ~CancelHandwritingStrokesFunction() {}
+ virtual bool RunImpl() OVERRIDE;
};
#endif
« no previous file with comments | « chrome/browser/extensions/extension_info_map.cc ('k') | chrome/browser/extensions/extension_input_ime_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698