Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Unified Diff: chrome/browser/extensions/extension_context_menu_api.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_context_menu_api.h
diff --git a/chrome/browser/extensions/extension_context_menu_api.h b/chrome/browser/extensions/extension_context_menu_api.h
index dc6e4d9755f3d7eafd0a886dfafbf577f02fd17e..840ac5a9e546d883de8073ec7838c3ce464b24f5 100644
--- a/chrome/browser/extensions/extension_context_menu_api.h
+++ b/chrome/browser/extensions/extension_context_menu_api.h
@@ -17,10 +17,9 @@ class DictionaryValue;
}
class ExtensionContextMenuFunction : public SyncExtensionFunction {
- public:
+ protected:
virtual ~ExtensionContextMenuFunction() {}
- protected:
// Helper function to read and parse a list of menu item contexts.
bool ParseContexts(const base::DictionaryValue& properties,
const char* key,
@@ -63,27 +62,47 @@ class ExtensionContextMenuFunction : public SyncExtensionFunction {
};
class CreateContextMenuFunction : public ExtensionContextMenuFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("contextMenus.create")
+
+ protected:
virtual ~CreateContextMenuFunction() {}
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("contextMenus.create")
};
class UpdateContextMenuFunction : public ExtensionContextMenuFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("contextMenus.update")
+
+ protected:
virtual ~UpdateContextMenuFunction() {}
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("contextMenus.update")
};
class RemoveContextMenuFunction : public ExtensionContextMenuFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("contextMenus.remove")
+
+ protected:
virtual ~RemoveContextMenuFunction() {}
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("contextMenus.remove")
};
class RemoveAllContextMenusFunction : public ExtensionContextMenuFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("contextMenus.removeAll")
+
+ protected:
virtual ~RemoveAllContextMenusFunction() {}
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("contextMenus.removeAll")
};
#endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_CONTEXT_MENU_API_H__
« no previous file with comments | « chrome/browser/extensions/extension_content_settings_api.h ('k') | chrome/browser/extensions/extension_context_menu_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698