Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4307)

Unified Diff: chrome/browser/extensions/api/declarative/initializing_rules_registry.cc

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/declarative/initializing_rules_registry.cc
diff --git a/chrome/browser/extensions/api/declarative/initializing_rules_registry.cc b/chrome/browser/extensions/api/declarative/initializing_rules_registry.cc
index 618d5f8fa64b860dea15d72edec9a1c4845b234e..4ecaf239529b7b1de0160fabe83202abffbc645c 100644
--- a/chrome/browser/extensions/api/declarative/initializing_rules_registry.cc
+++ b/chrome/browser/extensions/api/declarative/initializing_rules_registry.cc
@@ -22,8 +22,6 @@ InitializingRulesRegistry::InitializingRulesRegistry(
last_generated_rule_identifier_id_(0) {
}
-InitializingRulesRegistry::~InitializingRulesRegistry() {}
-
std::string InitializingRulesRegistry::AddRules(
const std::string& extension_id,
const std::vector<linked_ptr<RulesRegistry::Rule> >& rules) {
@@ -75,6 +73,8 @@ content::BrowserThread::ID InitializingRulesRegistry::GetOwnerThread() const {
return delegate_->GetOwnerThread();
}
+InitializingRulesRegistry::~InitializingRulesRegistry() {}
+
bool InitializingRulesRegistry::IsUniqueId(
const std::string& extension_id,
const std::string& rule_id) const {
@@ -92,19 +92,6 @@ std::string InitializingRulesRegistry::GenerateUniqueId(
return ToId(last_generated_rule_identifier_id_);
}
-void InitializingRulesRegistry::RemoveUsedRuleIdentifiers(
- const std::string& extension_id,
- const std::vector<std::string>& identifiers) {
- std::vector<std::string>::const_iterator i;
- for (i = identifiers.begin(); i != identifiers.end(); ++i)
- used_rule_identifiers_[extension_id].erase(*i);
-}
-
-void InitializingRulesRegistry::RemoveAllUsedRuleIdentifiers(
- const std::string& extension_id) {
- used_rule_identifiers_.erase(extension_id);
-}
-
std::string InitializingRulesRegistry::CheckAndFillInOptionalRules(
const std::string& extension_id,
const std::vector<linked_ptr<RulesRegistry::Rule> >& rules) {
@@ -147,4 +134,17 @@ void InitializingRulesRegistry::FillInOptionalPriorities(
}
}
+void InitializingRulesRegistry::RemoveUsedRuleIdentifiers(
+ const std::string& extension_id,
+ const std::vector<std::string>& identifiers) {
+ std::vector<std::string>::const_iterator i;
+ for (i = identifiers.begin(); i != identifiers.end(); ++i)
+ used_rule_identifiers_[extension_id].erase(*i);
+}
+
+void InitializingRulesRegistry::RemoveAllUsedRuleIdentifiers(
+ const std::string& extension_id) {
+ used_rule_identifiers_.erase(extension_id);
+}
+
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698