Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api_helpers.cc

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_request/web_request_api_helpers.cc
diff --git a/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc b/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc
index 60b3807f492588609d74592d4795f931f21ccf0c..871f29aeb4a517602ce967d6f2c76f434fd9d286 100644
--- a/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc
+++ b/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc
@@ -78,7 +78,6 @@ class NetLogExtensionIdParameter : public net::NetLog::EventParameters {
public:
explicit NetLogExtensionIdParameter(const std::string& extension_id)
: extension_id_(extension_id) {}
- virtual ~NetLogExtensionIdParameter() {}
virtual base::Value* ToValue() const OVERRIDE {
DictionaryValue* dict = new DictionaryValue();
@@ -86,6 +85,9 @@ class NetLogExtensionIdParameter : public net::NetLog::EventParameters {
return dict;
}
+ protected:
+ virtual ~NetLogExtensionIdParameter() {}
+
private:
const std::string extension_id_;
@@ -98,7 +100,6 @@ class NetLogModificationParameter : public NetLogExtensionIdParameter {
public:
explicit NetLogModificationParameter(const std::string& extension_id)
: NetLogExtensionIdParameter(extension_id) {}
- virtual ~NetLogModificationParameter() {}
virtual base::Value* ToValue() const OVERRIDE {
Value* parent = NetLogExtensionIdParameter::ToValue();
@@ -118,6 +119,8 @@ class NetLogModificationParameter : public NetLogExtensionIdParameter {
}
private:
+ virtual ~NetLogModificationParameter() {}
+
ListValue modified_headers_;
ListValue deleted_headers_;
« no previous file with comments | « chrome/browser/extensions/api/web_request/web_request_api.cc ('k') | chrome/browser/extensions/app_notification_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698