RefCounted types should not have public destructors, chrome/browser/extensions

chrome/browser/extensions/extension_idle_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_idle_api.h"
 
 #include <algorithm>
 #include <map>
 #include <string>
 
@@ skipping 115 matching lines @@
 StringValue* CreateIdleValue(IdleState idle_state) {
   StringValue* result = new StringValue(IdleStateToDescription(idle_state));
   return result;
 }
 
 int CheckThresholdBounds(int timeout) {
   if (timeout < kMinThreshold) return kMinThreshold;
   if (timeout > kMaxThreshold) return kMaxThreshold;
   return timeout;
 }
+
 };  // namespace
 
-void ExtensionIdleQueryStateFunction::IdleStateCallback(int threshold,
-                                                        IdleState state) {
-  // If our state is not active, make sure we're running a polling task to check
-  // for active state and report it when it changes to active.
-  if (state != IDLE_STATE_ACTIVE) {
-    ExtensionIdlePollingTask::CreateNewPollTask(threshold, state, profile_);
-  }
+void ExtensionIdleEventRouter::OnIdleStateChange(Profile* profile,
+                                                 IdleState state) {
+  // Prepare the single argument of the current state.
+  ListValue args;
+  args.Append(CreateIdleValue(state));
+  std::string json_args;
+  base::JSONWriter::Write(&args, &json_args);
 
-  result_.reset(CreateIdleValue(state));
-
-  ExtensionIdleCache::UpdateCache(threshold, state);
-
-  SendResponse(true);
+  profile->GetExtensionEventRouter()->DispatchEventToRenderers(
+      keys::kOnStateChanged, json_args, profile, GURL());
 }
 
 bool ExtensionIdleQueryStateFunction::RunImpl() {
   int threshold;
   EXTENSION_FUNCTION_VALIDATE(args_->GetInteger(0, &threshold));
   threshold = CheckThresholdBounds(threshold);
 
   IdleState state = ExtensionIdleCache::CalculateIdleState(threshold);
   if (state != IDLE_STATE_UNKNOWN) {
     result_.reset(CreateIdleValue(state));
     SendResponse(true);
     return true;
   }
 
   CalculateIdleState(threshold,
       base::Bind(&ExtensionIdleQueryStateFunction::IdleStateCallback,
                  this, threshold));
   // Don't send the response, it'll be sent by our callback
   return true;
 }
 
-void ExtensionIdleEventRouter::OnIdleStateChange(Profile* profile,
-                                                 IdleState state) {
-  // Prepare the single argument of the current state.
-  ListValue args;
-  args.Append(CreateIdleValue(state));
-  std::string json_args;
-  base::JSONWriter::Write(&args, &json_args);
+void ExtensionIdleQueryStateFunction::IdleStateCallback(int threshold,
+                                                        IdleState state) {
+  // If our state is not active, make sure we're running a polling task to check
+  // for active state and report it when it changes to active.
+  if (state != IDLE_STATE_ACTIVE) {
+    ExtensionIdlePollingTask::CreateNewPollTask(threshold, state, profile_);
+  }
 
-  profile->GetExtensionEventRouter()->DispatchEventToRenderers(
-      keys::kOnStateChanged, json_args, profile, GURL());
+  result_.reset(CreateIdleValue(state));
+
+  ExtensionIdleCache::UpdateCache(threshold, state);
+
+  SendResponse(true);
 }
 
 ExtensionIdleCache::CacheData ExtensionIdleCache::cached_data =
     {-1, -1, -1, -1};
 
 IdleState ExtensionIdleCache::CalculateIdleState(int threshold) {
   return CalculateState(threshold, base::Time::Now().ToDoubleT());
 }
 
+void ExtensionIdleCache::UpdateCache(int threshold, IdleState state) {
+  Update(threshold, state, base::Time::Now().ToDoubleT());
+}
+
 IdleState ExtensionIdleCache::CalculateState(int threshold, double now) {
   if (threshold < kMinThreshold)
     return IDLE_STATE_UNKNOWN;
   double threshold_moment = now - static_cast<double>(threshold);
   double throttle_interval = static_cast<double>(kThrottleInterval);
 
   // We test for IDEL_STATE_LOCKED first, because the result should be
   // independent of the data for idle and active state. If last state was
   // LOCKED and test for LOCKED is satisfied we should always return LOCKED.
   if (cached_data.latest_locked > 0 &&
@@ skipping 13 matching lines @@
   double error_from_idle =
       QueryErrorFromIdle(cached_data.idle_interval_start,
           cached_data.idle_interval_end, threshold_moment, now);
   if (cached_data.idle_interval_end > 0 &&
       error_from_idle < throttle_interval)
     return IDLE_STATE_IDLE;
 
   return IDLE_STATE_UNKNOWN;
 }
 
-void ExtensionIdleCache::UpdateCache(int threshold, IdleState state) {
-  Update(threshold, state, base::Time::Now().ToDoubleT());
-}
-
 void ExtensionIdleCache::Update(int threshold, IdleState state, double now) {
   if (threshold < kMinThreshold)
     return;
   double threshold_moment = now - static_cast<double>(threshold);
   switch (state) {
     case IDLE_STATE_IDLE:
       if (threshold_moment > cached_data.idle_interval_end) {
         // Cached and new interval don't overlap. We disregard the cached one.
         cached_data.idle_interval_start = threshold_moment;
       } else {
@@ skipping 23 matching lines @@
   }
 }
 
 int ExtensionIdleCache::get_min_threshold() {
   return kMinThreshold;
 }
 
 double ExtensionIdleCache::get_throttle_interval() {
   return static_cast<double>(kThrottleInterval);
 }