RefCounted types should not have public destructors, chrome/browser/extensions

chrome/browser/extensions/extension_test_api.h

Index: chrome/browser/extensions/extension_test_api.h
diff --git a/chrome/browser/extensions/extension_test_api.h b/chrome/browser/extensions/extension_test_api.h
index 6b653a98796eb81232f332a8cf142d9e7ad47668..518a8075715400cf9269ae49d01cc7eb1ed26cf5 100644
--- a/chrome/browser/extensions/extension_test_api.h
+++ b/chrome/browser/extensions/extension_test_api.h
@@ -14,61 +14,92 @@ template <typename T> struct DefaultSingletonTraits;
 // A function that is only available in tests.
 // Prior to running, checks that we are in an extension process.
 class TestExtensionFunction : public SyncExtensionFunction {
- public:
+ protected:
   virtual ~TestExtensionFunction();
 
+  // ExtensionFunction:
   virtual void Run() OVERRIDE;
 };
 
 class ExtensionTestPassFunction : public TestExtensionFunction {
+ public:
+  DECLARE_EXTENSION_FUNCTION_NAME("test.notifyPass")
+
+ protected:
   virtual ~ExtensionTestPassFunction();
+
+  // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
-  DECLARE_EXTENSION_FUNCTION_NAME("test.notifyPass")
 };
 
 class ExtensionTestFailFunction : public TestExtensionFunction {
+ public:
+  DECLARE_EXTENSION_FUNCTION_NAME("test.notifyFail")
+
+ protected:
   virtual ~ExtensionTestFailFunction();
+
+  // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
-  DECLARE_EXTENSION_FUNCTION_NAME("test.notifyFail")
 };
 
 class ExtensionTestLogFunction : public TestExtensionFunction {
+ public:
+  DECLARE_EXTENSION_FUNCTION_NAME("test.log")
+
+ protected:
   virtual ~ExtensionTestLogFunction();
+
+  // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
-  DECLARE_EXTENSION_FUNCTION_NAME("test.log")
 };
 
 class ExtensionTestQuotaResetFunction : public TestExtensionFunction {
+ public:
+  DECLARE_EXTENSION_FUNCTION_NAME("test.resetQuota")
+
+ protected:
   virtual ~ExtensionTestQuotaResetFunction();
+
+  // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
-  DECLARE_EXTENSION_FUNCTION_NAME("test.resetQuota")
 };
 
 class ExtensionTestCreateIncognitoTabFunction : public TestExtensionFunction {
+ public:
+  DECLARE_EXTENSION_FUNCTION_NAME("test.createIncognitoTab")
+
+ protected:
   virtual ~ExtensionTestCreateIncognitoTabFunction();
+
+  // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
-  DECLARE_EXTENSION_FUNCTION_NAME("test.createIncognitoTab")
 };
 
 class ExtensionTestSendMessageFunction : public AsyncExtensionFunction {
  public:
+  DECLARE_EXTENSION_FUNCTION_NAME("test.sendMessage")
+
   // Sends a reply back to the calling extension. Many extensions don't need
   // a reply and will just ignore it.
   void Reply(const std::string& message);
 
- private:
+ protected:
   virtual ~ExtensionTestSendMessageFunction();
+
+  // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
-  DECLARE_EXTENSION_FUNCTION_NAME("test.sendMessage")
 };
 
 class ExtensionTestGetConfigFunction : public SyncExtensionFunction {
  public:
+  DECLARE_EXTENSION_FUNCTION_NAME("test.getConfig")
+
   // Set the dictionary returned by chrome.test.getConfig().
   // Does not take ownership of |value|.
   static void set_test_config_state(DictionaryValue* value);
 
- private:
+ protected:
   // Tests that set configuration state do so by calling
   // set_test_config_state() as part of test set up, and unsetting it
   // during tear down.  This singleton class holds a pointer to that
@@ -80,19 +111,24 @@ class ExtensionTestGetConfigFunction : public SyncExtensionFunction {
     void set_config_state(DictionaryValue* config_state) {
       config_state_ = config_state;
     }
+
     const DictionaryValue* config_state() {
       return config_state_;
     }
+
    private:
     friend struct DefaultSingletonTraits<TestConfigState>;
     TestConfigState();
+
     DictionaryValue* config_state_;
+
     DISALLOW_COPY_AND_ASSIGN(TestConfigState);
   };
 
   virtual ~ExtensionTestGetConfigFunction();
+
+  // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
-  DECLARE_EXTENSION_FUNCTION_NAME("test.getConfig")
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_TEST_API_H_