Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1559)

Unified Diff: chrome/browser/extensions/bundle_installer.cc

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/bundle_installer.cc
diff --git a/chrome/browser/extensions/bundle_installer.cc b/chrome/browser/extensions/bundle_installer.cc
index 68a92bb9a7333cc193cd873fa99d076cfcbc7703..174eaa55cb4239d7aa1889c99e5003a91a695045 100644
--- a/chrome/browser/extensions/bundle_installer.cc
+++ b/chrome/browser/extensions/bundle_installer.cc
@@ -113,10 +113,6 @@ BundleInstaller::BundleInstaller(Profile* profile,
}
}
-BundleInstaller::~BundleInstaller() {
- BrowserList::RemoveObserver(this);
-}
-
BundleInstaller::ItemList BundleInstaller::GetItemsWithState(
Item::State state) const {
ItemList list;
@@ -205,6 +201,10 @@ string16 BundleInstaller::GetHeadingTextFor(Item::State state) const {
return l10n_util::GetStringUTF16(msg_id);
}
+BundleInstaller::~BundleInstaller() {
+ BrowserList::RemoveObserver(this);
+}
+
void BundleInstaller::ParseManifests() {
if (items_.empty()) {
ReportCanceled(false);
@@ -331,15 +331,13 @@ void BundleInstaller::OnExtensionInstallFailure(const std::string& id,
ShowInstalledBubbleIfDone();
}
-void BundleInstaller::OnBrowserAdded(const Browser* browser) {
-}
+void BundleInstaller::OnBrowserAdded(const Browser* browser) {}
void BundleInstaller::OnBrowserRemoved(const Browser* browser) {
if (browser_ == browser)
browser_ = NULL;
}
-void BundleInstaller::OnBrowserSetLastActive(const Browser* browser) {
-}
+void BundleInstaller::OnBrowserSetLastActive(const Browser* browser) {}
} // namespace extensions
« no previous file with comments | « chrome/browser/extensions/bundle_installer.h ('k') | chrome/browser/extensions/execute_code_in_tab_function.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698