chrome/browser/extensions/bundle_installer.h - Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/bundle_installer.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Compile fix Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/bundle_installer.h

diff --git a/chrome/browser/extensions/bundle_installer.h b/chrome/browser/extensions/bundle_installer.h

index 40034e7e1dabb950ad10d7e244ac9623c9115cc4..4b91f9a6c82e1fe733fd7f9da36b10d1e72dfec6 100644

--- a/chrome/browser/extensions/bundle_installer.h

+++ b/chrome/browser/extensions/bundle_installer.h

@@ -77,7 +77,6 @@ class BundleInstaller : public WebstoreInstallHelper::Delegate,

typedef std::vector<Item> ItemList;

BundleInstaller(Profile* profile, const ItemList& items);

- virtual ~BundleInstaller();

// Returns true if the user has approved the bundle's permissions.

bool approved() const { return approved_; }

@@ -116,6 +115,8 @@ class BundleInstaller : public WebstoreInstallHelper::Delegate,

typedef std::map<std::string, Item> ItemMap;

typedef std::map<std::string, linked_ptr<base::DictionaryValue> > ManifestMap;

+ virtual ~BundleInstaller();

// Displays the install bubble for |bundle| on |browser|.

// Note: this is a platform specific implementation.

static void ShowInstalledBubble(const BundleInstaller* bundle,

« no previous file with comments | « chrome/browser/extensions/app_notification_manager.cc ('k') | chrome/browser/extensions/bundle_installer.cc » ('j') | no next file with comments »