chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc - Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Compile fix Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/mock_extension_special_storage_policy.cc ('k') | chrome/browser/extensions/settings/settings_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc

diff --git a/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc b/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc

index b458d38a82e9333dfb40730584132450cbee577d..205f14f3bde36a682bf80fbe06d7486c9768867c 100644

--- a/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc

+++ b/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc

@@ -41,8 +41,6 @@ void OnUnpackSuccess(const FilePath& temp_dir,

class MockSandboxedExtensionUnpackerClient

: public SandboxedExtensionUnpackerClient {

public:

- virtual ~MockSandboxedExtensionUnpackerClient() {}

MOCK_METHOD4(OnUnpackSuccess,

void(const FilePath& temp_dir,

const FilePath& extension_root,

@@ -56,6 +54,9 @@ class MockSandboxedExtensionUnpackerClient

ON_CALL(*this, OnUnpackSuccess(_, _, _, _))

.WillByDefault(Invoke(::OnUnpackSuccess));

}

+ protected:

+ virtual ~MockSandboxedExtensionUnpackerClient() {}

};

class SandboxedExtensionUnpackerTest : public testing::Test {