chrome/browser/extensions/api/terminal/terminal_private_api.cc - Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/terminal/terminal_private_api.cc

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Compile fix Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/terminal/terminal_private_api.h ('k') | chrome/browser/extensions/api/web_request/web_request_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/terminal/terminal_private_api.cc

diff --git a/chrome/browser/extensions/api/terminal/terminal_private_api.cc b/chrome/browser/extensions/api/terminal/terminal_private_api.cc

index 4bde458979c00f3270105ed6ba75725988e22cef..c70cfdffa0173eeac98ff8470cd30d45785d377e 100644

--- a/chrome/browser/extensions/api/terminal/terminal_private_api.cc

+++ b/chrome/browser/extensions/api/terminal/terminal_private_api.cc

@@ -67,21 +67,17 @@ void NotifyProcessOutput(Profile* profile,

} // namespace

-TerminalPrivateFunction::TerminalPrivateFunction() {

+TerminalPrivateFunction::TerminalPrivateFunction() {}

-TerminalPrivateFunction::~TerminalPrivateFunction() {

+TerminalPrivateFunction::~TerminalPrivateFunction() {}

bool TerminalPrivateFunction::RunImpl() {

return RunTerminalFunction();

}

-OpenTerminalProcessFunction::OpenTerminalProcessFunction() : command_(NULL) {

+OpenTerminalProcessFunction::OpenTerminalProcessFunction() : command_(NULL) {}

-OpenTerminalProcessFunction::~OpenTerminalProcessFunction() {

+OpenTerminalProcessFunction::~OpenTerminalProcessFunction() {}

bool OpenTerminalProcessFunction::RunTerminalFunction() {

if (args_->GetSize() != 1)