Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3219)

Unified Diff: chrome/browser/extensions/extension_metrics_module.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_management_api.h ('k') | chrome/browser/extensions/extension_module.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_metrics_module.h
diff --git a/chrome/browser/extensions/extension_metrics_module.h b/chrome/browser/extensions/extension_metrics_module.h
index 8c1ffa4865a4fa89f537562ac0045a32e10a62d7..117f96b8aa0eeacc44526f56230d01186e74255c 100644
--- a/chrome/browser/extensions/extension_metrics_module.h
+++ b/chrome/browser/extensions/extension_metrics_module.h
@@ -12,12 +12,19 @@
#include "chrome/browser/extensions/extension_function.h"
class MetricsRecordUserActionFunction : public SyncExtensionFunction {
- virtual bool RunImpl() OVERRIDE;
+ public:
DECLARE_EXTENSION_FUNCTION_NAME("metricsPrivate.recordUserAction")
+
+ protected:
+ virtual ~MetricsRecordUserActionFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class MetricsHistogramHelperFunction : public SyncExtensionFunction {
protected:
+ virtual ~MetricsHistogramHelperFunction() {}
bool GetNameAndSample(std::string* name, int* sample);
virtual bool RecordValue(const std::string& name,
base::Histogram::ClassType type,
@@ -25,43 +32,91 @@ class MetricsHistogramHelperFunction : public SyncExtensionFunction {
};
class MetricsRecordValueFunction : public MetricsHistogramHelperFunction {
- virtual bool RunImpl() OVERRIDE;
+ public:
DECLARE_EXTENSION_FUNCTION_NAME("metricsPrivate.recordValue")
+
+ protected:
+ virtual ~MetricsRecordValueFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class MetricsRecordPercentageFunction : public MetricsHistogramHelperFunction {
- virtual bool RunImpl() OVERRIDE;
+ public:
DECLARE_EXTENSION_FUNCTION_NAME("metricsPrivate.recordPercentage")
+
+ protected:
+ virtual ~MetricsRecordPercentageFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class MetricsRecordCountFunction : public MetricsHistogramHelperFunction {
- virtual bool RunImpl() OVERRIDE;
+ public:
DECLARE_EXTENSION_FUNCTION_NAME("metricsPrivate.recordCount")
+
+ protected:
+ virtual ~MetricsRecordCountFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class MetricsRecordSmallCountFunction : public MetricsHistogramHelperFunction {
- virtual bool RunImpl() OVERRIDE;
+ public:
DECLARE_EXTENSION_FUNCTION_NAME("metricsPrivate.recordSmallCount")
+
+ protected:
+ virtual ~MetricsRecordSmallCountFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class MetricsRecordMediumCountFunction : public MetricsHistogramHelperFunction {
- virtual bool RunImpl() OVERRIDE;
+ public:
DECLARE_EXTENSION_FUNCTION_NAME("metricsPrivate.recordMediumCount")
+
+ protected:
+ virtual ~MetricsRecordMediumCountFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class MetricsRecordTimeFunction : public MetricsHistogramHelperFunction {
- virtual bool RunImpl() OVERRIDE;
+ public:
DECLARE_EXTENSION_FUNCTION_NAME("metricsPrivate.recordTime")
+
+ protected:
+ virtual ~MetricsRecordTimeFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class MetricsRecordMediumTimeFunction : public MetricsHistogramHelperFunction {
- virtual bool RunImpl() OVERRIDE;
+ public:
DECLARE_EXTENSION_FUNCTION_NAME("metricsPrivate.recordMediumTime")
+
+ protected:
+ virtual ~MetricsRecordMediumTimeFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class MetricsRecordLongTimeFunction : public MetricsHistogramHelperFunction {
- virtual bool RunImpl() OVERRIDE;
+ public:
DECLARE_EXTENSION_FUNCTION_NAME("metricsPrivate.recordLongTime")
+
+ protected:
+ virtual ~MetricsRecordLongTimeFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
#endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_METRICS_MODULE_H__
« no previous file with comments | « chrome/browser/extensions/extension_management_api.h ('k') | chrome/browser/extensions/extension_module.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698