RefCounted types should not have public destructors, chrome/browser/extensions

chrome/browser/extensions/extension_webstore_private_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_WEBSTORE_PRIVATE_API_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_WEBSTORE_PRIVATE_API_H_
 #pragma once
 
 #include <string>
 
@@ skipping 30 matching lines @@
   // Gets the pending approval for the |extension_id| in |profile|. Pending
   // approvals are held between the calls to beginInstallWithManifest and
   // completeInstall. This should only be used for testing.
   static scoped_ptr<WebstoreInstaller::Approval> PopApprovalForTesting(
       Profile* profile, const std::string& extension_id);
 };
 
 class InstallBundleFunction : public AsyncExtensionFunction,
                               public extensions::BundleInstaller::Delegate {
  public:
+  DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.installBundle");
+
   InstallBundleFunction();
 
-  // BundleInstaller::Delegate implementation.
+  // BundleInstaller::Delegate:
   virtual void OnBundleInstallApproved() OVERRIDE;
   virtual void OnBundleInstallCanceled(bool user_initiated) OVERRIDE;
   virtual void OnBundleInstallCompleted() OVERRIDE;
 
  protected:
   virtual ~InstallBundleFunction();
+
+  // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
 
   // Reads the extension |details| into |items|.
   bool ReadBundleInfo(base::ListValue* details,
                       extensions::BundleInstaller::ItemList* items);
 
  private:
   scoped_refptr<extensions::BundleInstaller> bundle_;
-  DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.installBundle");
 };
 
 class BeginInstallWithManifestFunction
     : public AsyncExtensionFunction,
       public ExtensionInstallUI::Delegate,
       public WebstoreInstallHelper::Delegate {
  public:
-  BeginInstallWithManifestFunction();
+  DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.beginInstallWithManifest3");
 
   // Result codes for the return value. If you change this, make sure to
   // update the description for the beginInstallWithManifest3 callback in
   // the extension API JSON.
   enum ResultCode {
     ERROR_NONE = 0,
 
     // An unspecified error occurred.
     UNKNOWN_ERROR,
 
     // The user cancelled the confirmation dialog instead of accepting it.
     USER_CANCELLED,
 
     // The manifest failed to parse correctly.
     MANIFEST_ERROR,
 
     // There was a problem parsing the base64 encoded icon data.
     ICON_ERROR,
 
     // The extension id was invalid.
     INVALID_ID,
 
     // The page does not have permission to call this function.
     PERMISSION_DENIED,
 
     // Invalid icon url.
     INVALID_ICON_URL
   };
 
-  // Implementing WebstoreInstallHelper::Delegate interface.
+  BeginInstallWithManifestFunction();
+
+  // WebstoreInstallHelper::Delegate:
   virtual void OnWebstoreParseSuccess(
       const std::string& id,
       const SkBitmap& icon,
       base::DictionaryValue* parsed_manifest) OVERRIDE;
   virtual void OnWebstoreParseFailure(
       const std::string& id,
       InstallHelperResultCode result_code,
       const std::string& error_message) OVERRIDE;
 
-  // Implementing ExtensionInstallUI::Delegate interface.
+  // ExtensionInstallUI::Delegate:
   virtual void InstallUIProceed() OVERRIDE;
   virtual void InstallUIAbort(bool user_initiated) OVERRIDE;
 
  protected:
   virtual ~BeginInstallWithManifestFunction();
+
+  // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
 
   // Sets the result_ as a string based on |code|.
   void SetResult(ResultCode code);
 
  private:
   // These store the input parameters to the function.
   std::string id_;
   std::string manifest_;
   std::string icon_data_;
   std::string localized_name_;
   bool use_app_installed_bubble_;
 
   // The results of parsing manifest_ and icon_data_ go into these two.
   scoped_ptr<base::DictionaryValue> parsed_manifest_;
   SkBitmap icon_;
 
   // A dummy Extension object we create for the purposes of using
   // ExtensionInstallUI to prompt for confirmation of the install.
   scoped_refptr<Extension> dummy_extension_;
 
   // The class that displays the install prompt.
   scoped_ptr<ExtensionInstallUI> install_ui_;
-
-  DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.beginInstallWithManifest3");
 };
 
 class CompleteInstallFunction : public SyncExtensionFunction {
+ public:
+  DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.completeInstall");
+
+ protected:
+  virtual ~CompleteInstallFunction() {}
+
+  // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
-  DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.completeInstall");
 };
 
 class SilentlyInstallFunction : public AsyncExtensionFunction,
                                 public WebstoreInstallHelper::Delegate,
                                 public WebstoreInstaller::Delegate {
  public:
+  DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.silentlyInstall");
+
   SilentlyInstallFunction();
 
-  // WebstoreInstallHelper::Delegate implementation.
+  // WebstoreInstallHelper::Delegate:
   virtual void OnWebstoreParseSuccess(
       const std::string& id,
       const SkBitmap& icon,
       base::DictionaryValue* parsed_manifest) OVERRIDE;
   virtual void OnWebstoreParseFailure(
       const std::string& id,
       InstallHelperResultCode result_code,
       const std::string& error_message) OVERRIDE;
 
-  // WebstoreInstaller::Delegate implementation.
+  // WebstoreInstaller::Delegate:
   virtual void OnExtensionInstallSuccess(const std::string& id) OVERRIDE;
   virtual void OnExtensionInstallFailure(const std::string& id,
                                          const std::string& error) OVERRIDE;
 
  protected:
   virtual ~SilentlyInstallFunction();
+
+  // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
 
  private:
   std::string id_;
   std::string manifest_;
-  DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.silentlyInstall");
 };
 
 class GetBrowserLoginFunction : public SyncExtensionFunction {
+ public:
+  DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.getBrowserLogin");
+
+ protected:
+  virtual ~GetBrowserLoginFunction() {}
+
+  // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
-  DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.getBrowserLogin");
 };
 
 class GetStoreLoginFunction : public SyncExtensionFunction {
+ public:
+  DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.getStoreLogin");
+
+ protected:
+  virtual ~GetStoreLoginFunction() {}
+
+  // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
-  DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.getStoreLogin");
 };
 
 class SetStoreLoginFunction : public SyncExtensionFunction {
+ public:
+  DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.setStoreLogin");
+
+ protected:
+  virtual ~SetStoreLoginFunction() {}
+
+  // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
-  DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.setStoreLogin");
 };
 
 class GetWebGLStatusFunction : public AsyncExtensionFunction,
                                public content::GpuDataManagerObserver {
  public:
+  DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.getWebGLStatus");
+
   GetWebGLStatusFunction();
 
-  // Implementing GpuDataManagerObserver interface.
+  // content::GpuDataManagerObserver:
   virtual void OnGpuInfoUpdate() OVERRIDE;
 
  protected:
   virtual ~GetWebGLStatusFunction();
+
+  // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
 
  private:
   void CreateResult(bool webgl_allowed);
 
   // A false return value is always valid, but a true one is only valid if full
   // GPU info has been collected in a GPU process.
   static bool IsWebGLAllowed(content::GpuDataManager* manager);
-
-  DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.getWebGLStatus");
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_WEBSTORE_PRIVATE_API_H_