Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: chrome/browser/extensions/api/permissions/permissions_api.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/permissions/permissions_api.h
diff --git a/chrome/browser/extensions/api/permissions/permissions_api.h b/chrome/browser/extensions/api/permissions/permissions_api.h
index c52140d8e9a8f8d152930dcb950679554c340974..97bf0acbbddfe03ea7a24bc233f20c7d723a7353 100644
--- a/chrome/browser/extensions/api/permissions/permissions_api.h
+++ b/chrome/browser/extensions/api/permissions/permissions_api.h
@@ -19,47 +19,65 @@ class ExtensionService;
// chrome.permissions.contains
class ContainsPermissionsFunction : public SyncExtensionFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("permissions.contains")
+
+ protected:
virtual ~ContainsPermissionsFunction() {}
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("permissions.contains")
};
// chrome.permissions.getAll
class GetAllPermissionsFunction : public SyncExtensionFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("permissions.getAll")
+
+ protected:
virtual ~GetAllPermissionsFunction() {}
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("permissions.getAll")
};
// chrome.permissions.remove
class RemovePermissionsFunction : public SyncExtensionFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("permissions.remove")
+
+ protected:
virtual ~RemovePermissionsFunction() {}
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("permissions.remove")
};
// chrome.permissions.request
class RequestPermissionsFunction : public AsyncExtensionFunction,
public ExtensionInstallUI::Delegate {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("permissions.request")
+
+ RequestPermissionsFunction();
+
// FOR TESTS ONLY to bypass the confirmation UI.
static void SetAutoConfirmForTests(bool should_proceed);
static void SetIgnoreUserGestureForTests(bool ignore);
- RequestPermissionsFunction();
-
- // Implementing ExtensionInstallUI::Delegate interface.
+ // ExtensionInstallUI::Delegate:
virtual void InstallUIProceed() OVERRIDE;
virtual void InstallUIAbort(bool user_initiated) OVERRIDE;
protected:
virtual ~RequestPermissionsFunction();
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
private:
scoped_ptr<ExtensionInstallUI> install_ui_;
scoped_refptr<ExtensionPermissionSet> requested_permissions_;
- DECLARE_EXTENSION_FUNCTION_NAME("permissions.request")
};
#endif // CHROME_BROWSER_EXTENSIONS_API_PERMISSIONS_PERMISSIONS_API_H_

Powered by Google App Engine
This is Rietveld 408576698