RefCounted types should not have public destructors, chrome/browser/extensions

chrome/browser/extensions/api/browsing_data/browsing_data_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Defines the Chrome Extensions BrowsingData API functions, which entail
 // clearing browsing data, and clearing the browser's cache (which, let's be
 // honest, are the same thing), as specified in the extension API JSON.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_BROWSING_DATA_BROWSING_DATA_API_H_
 #define CHROME_BROWSER_EXTENSIONS_API_BROWSING_DATA_BROWSING_DATA_API_H_
@@ skipping 36 matching lines @@
 // function).
 //
 // Each child class must implement GetRemovalMask(), which returns the bitmask
 // of data types to remove.
 class BrowsingDataExtensionFunction : public AsyncExtensionFunction,
                                       public BrowsingDataRemover::Observer {
  public:
   // BrowsingDataRemover::Observer interface method.
   virtual void OnBrowsingDataRemoverDone() OVERRIDE;
 
-  // AsyncExtensionFunction interface method.
+  // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
 
  protected:
+  virtual ~BrowsingDataExtensionFunction() {}
+
   // Children should override this method to provide the proper removal mask
   // based on the API call they represent.
   virtual int GetRemovalMask() const = 0;
 
  private:
   // Updates the removal bitmask according to whether removing plugin data is
   // supported or not.
   void CheckRemovingPluginDataSupported(
       scoped_refptr<PluginPrefs> plugin_prefs);
 
   // Called when we're ready to start removing data.
   void StartRemoving();
 
   base::Time remove_since_;
   int removal_mask_;
 };
 
 class RemoveAppCacheFunction : public BrowsingDataExtensionFunction {
  public:
-  RemoveAppCacheFunction() {}
+  DECLARE_EXTENSION_FUNCTION_NAME("browsingData.removeAppcache")
+
+ protected:
   virtual ~RemoveAppCacheFunction() {}
 
- protected:
-  // BrowsingDataTypeExtensionFunction interface method.
+  // BrowsingDataTypeExtensionFunction:
   virtual int GetRemovalMask() const OVERRIDE;
-
-  DECLARE_EXTENSION_FUNCTION_NAME("browsingData.removeAppcache")
 };
 
 class RemoveBrowsingDataFunction : public BrowsingDataExtensionFunction {
  public:
-  RemoveBrowsingDataFunction() {}
+  DECLARE_EXTENSION_FUNCTION_NAME("browsingData.remove")
+
+ protected:
   virtual ~RemoveBrowsingDataFunction() {}
 
- protected:
-  // BrowsingDataExtensionFunction interface method.
+  // BrowsingDataExtensionFunction:
   virtual int GetRemovalMask() const OVERRIDE;
-
-  DECLARE_EXTENSION_FUNCTION_NAME("browsingData.remove")
 };
 
 class RemoveCacheFunction : public BrowsingDataExtensionFunction {
  public:
-  RemoveCacheFunction() {}
+  DECLARE_EXTENSION_FUNCTION_NAME("browsingData.removeCache")
+
+ protected:
   virtual ~RemoveCacheFunction() {}
 
- protected:
-  // BrowsingDataTypeExtensionFunction interface method.
+  // BrowsingDataExtensionFunction:
   virtual int GetRemovalMask() const OVERRIDE;
-
-  DECLARE_EXTENSION_FUNCTION_NAME("browsingData.removeCache")
 };
 
 class RemoveCookiesFunction : public BrowsingDataExtensionFunction {
  public:
-  RemoveCookiesFunction() {}
+  DECLARE_EXTENSION_FUNCTION_NAME("browsingData.removeCookies")
+
+ protected:
   virtual ~RemoveCookiesFunction() {}
 
- protected:
-  // BrowsingDataTypeExtensionFunction interface method.
+  // BrowsingDataExtensionFunction:
   virtual int GetRemovalMask() const OVERRIDE;
-
-  DECLARE_EXTENSION_FUNCTION_NAME("browsingData.removeCookies")
 };
 
 class RemoveDownloadsFunction : public BrowsingDataExtensionFunction {
  public:
-  RemoveDownloadsFunction() {}
+  DECLARE_EXTENSION_FUNCTION_NAME("browsingData.removeDownloads")
+
+ protected:
   virtual ~RemoveDownloadsFunction() {}
 
- protected:
-  // BrowsingDataTypeExtensionFunction interface method.
+  // BrowsingDataExtensionFunction:
   virtual int GetRemovalMask() const OVERRIDE;
-
-  DECLARE_EXTENSION_FUNCTION_NAME("browsingData.removeDownloads")
 };
 
 class RemoveFileSystemsFunction : public BrowsingDataExtensionFunction {
  public:
-  RemoveFileSystemsFunction() {}
+  DECLARE_EXTENSION_FUNCTION_NAME("browsingData.removeFileSystems")
+
+ protected:
   virtual ~RemoveFileSystemsFunction() {}
 
- protected:
-  // BrowsingDataTypeExtensionFunction interface method.
+  // BrowsingDataExtensionFunction:
   virtual int GetRemovalMask() const OVERRIDE;
-
-  DECLARE_EXTENSION_FUNCTION_NAME("browsingData.removeFileSystems")
 };
 
 class RemoveFormDataFunction : public BrowsingDataExtensionFunction {
  public:
-  RemoveFormDataFunction() {}
+  DECLARE_EXTENSION_FUNCTION_NAME("browsingData.removeFormData")
+
+ protected:
   virtual ~RemoveFormDataFunction() {}
 
- protected:
-  // BrowsingDataTypeExtensionFunction interface method.
+  // BrowsingDataExtensionFunction:
   virtual int GetRemovalMask() const OVERRIDE;
-
-  DECLARE_EXTENSION_FUNCTION_NAME("browsingData.removeFormData")
 };
 
 class RemoveHistoryFunction : public BrowsingDataExtensionFunction {
  public:
-  RemoveHistoryFunction() {}
+  DECLARE_EXTENSION_FUNCTION_NAME("browsingData.removeHistory")
+
+ protected:
   virtual ~RemoveHistoryFunction() {}
 
- protected:
-  // BrowsingDataTypeExtensionFunction interface method.
+  // BrowsingDataExtensionFunction:
   virtual int GetRemovalMask() const OVERRIDE;
-
-  DECLARE_EXTENSION_FUNCTION_NAME("browsingData.removeHistory")
 };
 
 class RemoveIndexedDBFunction : public BrowsingDataExtensionFunction {
  public:
-  RemoveIndexedDBFunction() {}
+  DECLARE_EXTENSION_FUNCTION_NAME("browsingData.removeIndexedDB")
+
+ protected:
   virtual ~RemoveIndexedDBFunction() {}
 
- protected:
-  // BrowsingDataTypeExtensionFunction interface method.
+  // BrowsingDataExtensionFunction:
   virtual int GetRemovalMask() const OVERRIDE;
-
-  DECLARE_EXTENSION_FUNCTION_NAME("browsingData.removeIndexedDB")
 };
 
 class RemoveLocalStorageFunction : public BrowsingDataExtensionFunction {
  public:
-  RemoveLocalStorageFunction() {}
+  DECLARE_EXTENSION_FUNCTION_NAME("browsingData.removeLocalStorage")
+
+ protected:
   virtual ~RemoveLocalStorageFunction() {}
 
- protected:
-  // BrowsingDataTypeExtensionFunction interface method.
+  // BrowsingDataExtensionFunction:
   virtual int GetRemovalMask() const OVERRIDE;
-
-  DECLARE_EXTENSION_FUNCTION_NAME("browsingData.removeLocalStorage")
 };
 
 class RemoveServerBoundCertsFunction : public BrowsingDataExtensionFunction {
  public:
-  RemoveServerBoundCertsFunction() {}
+  DECLARE_EXTENSION_FUNCTION_NAME("browsingData.removeServerBoundCertificates")
+
+ protected:
   virtual ~RemoveServerBoundCertsFunction() {}
 
- protected:
-  // BrowsingDataTypeExtensionFunction interface method.
+  // BrowsingDataExtensionFunction:
   virtual int GetRemovalMask() const OVERRIDE;
-
-  DECLARE_EXTENSION_FUNCTION_NAME("browsingData.removeServerBoundCertificates")
 };
 
 class RemovePluginDataFunction : public BrowsingDataExtensionFunction {
  public:
-  RemovePluginDataFunction() {}
+  DECLARE_EXTENSION_FUNCTION_NAME("browsingData.removePluginData")
+
+ protected:
   virtual ~RemovePluginDataFunction() {}
 
- protected:
-  // BrowsingDataTypeExtensionFunction interface method.
+  // BrowsingDataExtensionFunction:
   virtual int GetRemovalMask() const OVERRIDE;
-
-  DECLARE_EXTENSION_FUNCTION_NAME("browsingData.removePluginData")
 };
 
 class RemovePasswordsFunction : public BrowsingDataExtensionFunction {
  public:
-  RemovePasswordsFunction() {}
+  DECLARE_EXTENSION_FUNCTION_NAME("browsingData.removePasswords")
+
+ protected:
   virtual ~RemovePasswordsFunction() {}
 
- protected:
-  // BrowsingDataTypeExtensionFunction interface method.
+  // BrowsingDataExtensionFunction:
   virtual int GetRemovalMask() const OVERRIDE;
-
-  DECLARE_EXTENSION_FUNCTION_NAME("browsingData.removePasswords")
 };
 
 class RemoveWebSQLFunction : public BrowsingDataExtensionFunction {
  public:
-  RemoveWebSQLFunction() {}
+  DECLARE_EXTENSION_FUNCTION_NAME("browsingData.removeWebSQL")
+
+ protected:
   virtual ~RemoveWebSQLFunction() {}
 
- protected:
-  // BrowsingDataTypeExtensionFunction interface method.
+  // BrowsingDataExtensionFunction:
   virtual int GetRemovalMask() const OVERRIDE;
+};
 
-  DECLARE_EXTENSION_FUNCTION_NAME("browsingData.removeWebSQL")
-};
 #endif  // CHROME_BROWSER_EXTENSIONS_API_BROWSING_DATA_BROWSING_DATA_API_H_