RefCounted types should not have public destructors, chrome/browser/extensions

chrome/browser/extensions/bundle_installer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/bundle_installer.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 95 matching lines @@
       browser_(NULL),
       profile_(profile),
       delegate_(NULL) {
   BrowserList::AddObserver(this);
   for (size_t i = 0; i < items.size(); ++i) {
     items_[items[i].id] = items[i];
     items_[items[i].id].state = Item::STATE_PENDING;
   }
 }
 
-BundleInstaller::~BundleInstaller() {
-  BrowserList::RemoveObserver(this);
-}
-
 BundleInstaller::ItemList BundleInstaller::GetItemsWithState(
     Item::State state) const {
   ItemList list;
 
   for (ItemMap::const_iterator i = items_.begin(); i != items_.end(); ++i) {
     if (i->second.state == state)
       list.push_back(i->second);
   }
 
   return list;
@@ skipping 68 matching lines @@
   CHECK_LT(static_cast<size_t>(state), arraysize(kHeadingIds));
   CHECK_LT(index, arraysize(kHeadingIds[state]));
 
   int msg_id = kHeadingIds[state][index];
   if (!msg_id)
     return string16();
 
   return l10n_util::GetStringUTF16(msg_id);
 }
 
+BundleInstaller::~BundleInstaller() {
+  BrowserList::RemoveObserver(this);
+}
+
 void BundleInstaller::ParseManifests() {
   if (items_.empty()) {
     ReportCanceled(false);
     return;
   }
 
   for (ItemMap::iterator i = items_.begin(); i != items_.end(); ++i) {
     scoped_refptr<WebstoreInstallHelper> helper = new WebstoreInstallHelper(
         this, i->first, i->second.manifest, "", GURL(), NULL);
     helper->Start();
@@ skipping 106 matching lines @@
   items_[id].state = Item::STATE_FAILED;
 
   ExtensionList::iterator i = std::find_if(
       dummy_extensions_.begin(), dummy_extensions_.end(), MatchIdFunctor(id));
   CHECK(dummy_extensions_.end() != i);
   dummy_extensions_.erase(i);
 
   ShowInstalledBubbleIfDone();
 }
 
-void BundleInstaller::OnBrowserAdded(const Browser* browser) {
-}
+void BundleInstaller::OnBrowserAdded(const Browser* browser) {}
 
 void BundleInstaller::OnBrowserRemoved(const Browser* browser) {
   if (browser_ == browser)
     browser_ = NULL;
 }
 
-void BundleInstaller::OnBrowserSetLastActive(const Browser* browser) {
-}
+void BundleInstaller::OnBrowserSetLastActive(const Browser* browser) {}
 
 }  // namespace extensions