RefCounted types should not have public destructors, chrome/browser/extensions

chrome/browser/extensions/api/declarative/initializing_rules_registry.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/declarative/initializing_rules_registry.h"
 
 #include "base/logging.h"
 #include "base/stringprintf.h"
 #include "base/values.h"
 
 namespace {
 std::string ToId(int identifier) {
   return StringPrintf("_%d_", identifier);
 }
 }  // namespace
 
 namespace extensions {
 
 InitializingRulesRegistry::InitializingRulesRegistry(
     scoped_refptr<RulesRegistry> delegate)
     : delegate_(delegate),
       last_generated_rule_identifier_id_(0) {
 }
 
-InitializingRulesRegistry::~InitializingRulesRegistry() {}
-
 std::string InitializingRulesRegistry::AddRules(
     const std::string& extension_id,
     const std::vector<linked_ptr<RulesRegistry::Rule> >& rules) {
   std::string error = CheckAndFillInOptionalRules(extension_id, rules);
   if (!error.empty())
     return error;
   FillInOptionalPriorities(rules);
   return delegate_->AddRules(extension_id, rules);
 }
 
@@ skipping 31 matching lines @@
 
 void InitializingRulesRegistry::OnExtensionUnloaded(
     const std::string& extension_id) {
   delegate_->OnExtensionUnloaded(extension_id);
 }
 
 content::BrowserThread::ID InitializingRulesRegistry::GetOwnerThread() const {
   return delegate_->GetOwnerThread();
 }
 
+InitializingRulesRegistry::~InitializingRulesRegistry() {}
+
 bool InitializingRulesRegistry::IsUniqueId(
     const std::string& extension_id,
     const std::string& rule_id) const {
   RuleIdentifiersMap::const_iterator identifiers =
       used_rule_identifiers_.find(extension_id);
   if (identifiers == used_rule_identifiers_.end())
     return true;
   return identifiers->second.find(rule_id) == identifiers->second.end();
 }
 
 std::string InitializingRulesRegistry::GenerateUniqueId(
     const std::string& extension_id) {
   while (!IsUniqueId(extension_id, ToId(last_generated_rule_identifier_id_)))
     ++last_generated_rule_identifier_id_;
   return ToId(last_generated_rule_identifier_id_);
 }
 
-void InitializingRulesRegistry::RemoveUsedRuleIdentifiers(
-    const std::string& extension_id,
-    const std::vector<std::string>& identifiers) {
-  std::vector<std::string>::const_iterator i;
-  for (i = identifiers.begin(); i != identifiers.end(); ++i)
-    used_rule_identifiers_[extension_id].erase(*i);
-}
-
-void InitializingRulesRegistry::RemoveAllUsedRuleIdentifiers(
-    const std::string& extension_id) {
-  used_rule_identifiers_.erase(extension_id);
-}
-
 std::string InitializingRulesRegistry::CheckAndFillInOptionalRules(
     const std::string& extension_id,
     const std::vector<linked_ptr<RulesRegistry::Rule> >& rules) {
   // IDs we have inserted, in case we need to rollback this operation.
   std::vector<std::string> rollback_log;
 
   // First we insert all rules with existing identifier, so that generated
   // identifiers cannot collide with identifiers passed by the caller.
   for (std::vector<linked_ptr<RulesRegistry::Rule> >::const_iterator i =
       rules.begin(); i != rules.end(); ++i) {
@@ skipping 22 matching lines @@
 
 void InitializingRulesRegistry::FillInOptionalPriorities(
     const std::vector<linked_ptr<RulesRegistry::Rule> >& rules) {
   std::vector<linked_ptr<RulesRegistry::Rule> >::const_iterator i;
   for (i = rules.begin(); i != rules.end(); ++i) {
     if (!(*i)->priority.get())
       (*i)->priority.reset(new int(DEFAULT_PRIORITY));
   }
 }
 
+void InitializingRulesRegistry::RemoveUsedRuleIdentifiers(
+    const std::string& extension_id,
+    const std::vector<std::string>& identifiers) {
+  std::vector<std::string>::const_iterator i;
+  for (i = identifiers.begin(); i != identifiers.end(); ++i)
+    used_rule_identifiers_[extension_id].erase(*i);
+}
+
+void InitializingRulesRegistry::RemoveAllUsedRuleIdentifiers(
+    const std::string& extension_id) {
+  used_rule_identifiers_.erase(extension_id);
+}
+
 }  // namespace extensions