Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5577)

Unified Diff: chrome/browser/extensions/api/socket/socket_api.cc

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/socket/socket_api.cc
diff --git a/chrome/browser/extensions/api/socket/socket_api.cc b/chrome/browser/extensions/api/socket/socket_api.cc
index c8409aa0b9d6e390593ae58162ec4e784419be7f..6b77b6ac174787dc0ac6ddc1507c3fd62bcb6740 100644
--- a/chrome/browser/extensions/api/socket/socket_api.cc
+++ b/chrome/browser/extensions/api/socket/socket_api.cc
@@ -27,9 +27,12 @@ const char kUDPOption[] = "udp";
const char kSocketNotFoundError[] = "Socket not found";
SocketCreateFunction::SocketCreateFunction()
- : src_id_(-1), event_notifier_(NULL) {
+ : src_id_(-1),
+ event_notifier_(NULL) {
}
+SocketCreateFunction::~SocketCreateFunction() {}
+
bool SocketCreateFunction::Prepare() {
std::string socket_type_string;
EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &socket_type_string));
@@ -182,8 +185,7 @@ SocketWriteFunction::SocketWriteFunction()
io_buffer_(NULL) {
}
-SocketWriteFunction::~SocketWriteFunction() {
-}
+SocketWriteFunction::~SocketWriteFunction() {}
bool SocketWriteFunction::Prepare() {
EXTENSION_FUNCTION_VALIDATE(args_->GetInteger(0, &socket_id_));
@@ -224,6 +226,8 @@ bool SocketWriteFunction::Respond() {
return true;
}
+SocketRecvFromFunction::~SocketRecvFromFunction() {}
+
bool SocketRecvFromFunction::Prepare() {
EXTENSION_FUNCTION_VALIDATE(args_->GetInteger(0, &socket_id_));
return true;
@@ -273,8 +277,7 @@ SocketSendToFunction::SocketSendToFunction()
io_buffer_(NULL) {
}
-SocketSendToFunction::~SocketSendToFunction() {
-}
+SocketSendToFunction::~SocketSendToFunction() {}
bool SocketSendToFunction::Prepare() {
EXTENSION_FUNCTION_VALIDATE(args_->GetInteger(0, &socket_id_));
« no previous file with comments | « chrome/browser/extensions/api/socket/socket_api.h ('k') | chrome/browser/extensions/api/socket/tcp_socket_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698