Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5565)

Unified Diff: chrome/browser/extensions/extension_cookies_api.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_cookies_api.h
diff --git a/chrome/browser/extensions/extension_cookies_api.h b/chrome/browser/extensions/extension_cookies_api.h
index c270e4199fdab4542a5735d3030fb39fca1e96f7..e9f72360d9ad6cbe8b312cc62d94ce6c7c51aabc 100644
--- a/chrome/browser/extensions/extension_cookies_api.h
+++ b/chrome/browser/extensions/extension_cookies_api.h
@@ -72,6 +72,8 @@ class ExtensionCookiesEventRouter : public content::NotificationObserver {
// See chrome/browser/extensions/extension_function.h for more information.
class CookiesFunction : public AsyncExtensionFunction {
protected:
+ virtual ~CookiesFunction() {}
+
// Looks for a 'url' value in the given details dictionary and constructs a
// GURL from it. Returns false and assigns the internal error_ value if the
// URL is invalid or isn't found in the dictionary. If check_host_permissions
@@ -95,10 +97,15 @@ class CookiesFunction : public AsyncExtensionFunction {
// Implements the cookies.get() extension function.
class GetCookieFunction : public CookiesFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("cookies.get")
+
GetCookieFunction();
+
+ protected:
virtual ~GetCookieFunction();
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("cookies.get")
private:
void GetCookieOnIOThread();
@@ -114,10 +121,15 @@ class GetCookieFunction : public CookiesFunction {
// Implements the cookies.getAll() extension function.
class GetAllCookiesFunction : public CookiesFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("cookies.getAll")
+
GetAllCookiesFunction();
+
+ protected:
virtual ~GetAllCookiesFunction();
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("cookies.getAll")
private:
void GetAllCookiesOnIOThread();
@@ -133,10 +145,13 @@ class GetAllCookiesFunction : public CookiesFunction {
// Implements the cookies.set() extension function.
class SetCookieFunction : public CookiesFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("cookies.set")
+
SetCookieFunction();
+
+ protected:
virtual ~SetCookieFunction();
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("cookies.set")
private:
void SetCookieOnIOThread();
@@ -160,10 +175,15 @@ class SetCookieFunction : public CookiesFunction {
// Implements the cookies.remove() extension function.
class RemoveCookieFunction : public CookiesFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("cookies.remove")
+
RemoveCookieFunction();
+
+ protected:
virtual ~RemoveCookieFunction();
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("cookies.remove")
private:
void RemoveCookieOnIOThread();
@@ -180,10 +200,15 @@ class RemoveCookieFunction : public CookiesFunction {
// Implements the cookies.getAllCookieStores() extension function.
class GetAllCookieStoresFunction : public CookiesFunction {
public:
- virtual bool RunImpl() OVERRIDE;
+ DECLARE_EXTENSION_FUNCTION_NAME("cookies.getAllCookieStores")
+
+ protected:
+ virtual ~GetAllCookieStoresFunction() {}
+
+ // ExtensionFunction:
// GetAllCookieStoresFunction is sync.
virtual void Run() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("cookies.getAllCookieStores")
+ virtual bool RunImpl() OVERRIDE;
};
#endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_COOKIES_API_H_
« no previous file with comments | « chrome/browser/extensions/extension_context_menu_model.cc ('k') | chrome/browser/extensions/extension_debugger_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698