Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h
diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h
index 08a84e6e6c0dd270503b42e19e64a5ff4c8a9d22..63a8ff61251cd2ba8bcb12658fe535b2165d1530 100644
--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h
+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h
@@ -6,8 +6,10 @@
#define CHROME_BROWSER_EXTENSIONS_API_DECLARATIVE_WEBREQUEST_WEBREQUEST_RULES_REGISTRY_H_
#pragma once
-#include <vector>
#include <list>
+#include <map>
+#include <set>
+#include <vector>
#include "base/memory/linked_ptr.h"
#include "chrome/browser/extensions/api/declarative/rules_registry_with_cache.h"
@@ -59,7 +61,6 @@ class WebRequestRule;
class WebRequestRulesRegistry : public RulesRegistryWithCache {
public:
WebRequestRulesRegistry();
- virtual ~WebRequestRulesRegistry();
// TODO(battre): This will become an implementation detail, because we need
// a way to also execute the actions of the rules.
@@ -87,13 +88,16 @@ class WebRequestRulesRegistry : public RulesRegistryWithCache {
bool IsEmpty() const;
private:
+ typedef std::map<URLMatcherConditionSet::ID, WebRequestRule*> RuleTriggers;
+ typedef std::map<WebRequestRule::GlobalRuleId, linked_ptr<WebRequestRule> >
+ RulesMap;
+
+ virtual ~WebRequestRulesRegistry();
+
// Map that tells us which WebRequestRule may match under the condition that
// the URLMatcherConditionSet::ID was returned by the |url_matcher_|.
- typedef std::map<URLMatcherConditionSet::ID, WebRequestRule*> RuleTriggers;
RuleTriggers rule_triggers_;
- typedef std::map<WebRequestRule::GlobalRuleId, linked_ptr<WebRequestRule> >
- RulesMap;
RulesMap webrequest_rules_;
URLMatcher url_matcher_;

Powered by Google App Engine
This is Rietveld 408576698