Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Unified Diff: chrome/browser/extensions/api/serial/serial_api.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/serial/serial_api.h
diff --git a/chrome/browser/extensions/api/serial/serial_api.h b/chrome/browser/extensions/api/serial/serial_api.h
index a70527fbcf40569d7799368a35270848cb9435f9..902d641a8bbdaa4eccedb357a82686d5581d70d6 100644
--- a/chrome/browser/extensions/api/serial/serial_api.h
+++ b/chrome/browser/extensions/api/serial/serial_api.h
@@ -18,9 +18,14 @@ extern const char kConnectionIdKey[];
class SerialOpenFunction : public AsyncIOAPIFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("experimental.serial.open")
+
SerialOpenFunction();
protected:
+ virtual ~SerialOpenFunction() {}
+
+ // AsyncIOAPIFunction:
virtual bool Prepare() OVERRIDE;
virtual void Work() OVERRIDE;
virtual bool Respond() OVERRIDE;
@@ -28,40 +33,50 @@ class SerialOpenFunction : public AsyncIOAPIFunction {
private:
int src_id_;
std::string port_;
-
- DECLARE_EXTENSION_FUNCTION_NAME("experimental.serial.open")
};
class SerialCloseFunction : public AsyncIOAPIFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("experimental.serial.close")
+
protected:
+ virtual ~SerialCloseFunction() {}
+
+ // AsyncIOAPIFunction:
virtual bool Prepare() OVERRIDE;
virtual void Work() OVERRIDE;
virtual bool Respond() OVERRIDE;
private:
int connection_id_;
-
- DECLARE_EXTENSION_FUNCTION_NAME("experimental.serial.close")
};
class SerialReadFunction : public AsyncIOAPIFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("experimental.serial.read")
+
protected:
+ virtual ~SerialReadFunction() {}
+
+ // AsyncIOAPIFunction:
virtual bool Prepare() OVERRIDE;
virtual void Work() OVERRIDE;
virtual bool Respond() OVERRIDE;
private:
int connection_id_;
-
- DECLARE_EXTENSION_FUNCTION_NAME("experimental.serial.read")
};
class SerialWriteFunction : public AsyncIOAPIFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("experimental.serial.write")
+
SerialWriteFunction();
- virtual ~SerialWriteFunction();
protected:
+ virtual ~SerialWriteFunction();
+
+ // AsyncIOAPIFunction:
virtual bool Prepare() OVERRIDE;
virtual void Work() OVERRIDE;
virtual bool Respond() OVERRIDE;
@@ -69,8 +84,6 @@ class SerialWriteFunction : public AsyncIOAPIFunction {
private:
int connection_id_;
scoped_refptr<net::IOBufferWithSize> io_buffer_;
-
- DECLARE_EXTENSION_FUNCTION_NAME("experimental.serial.write")
};
} // namespace extensions
« no previous file with comments | « chrome/browser/extensions/api/permissions/permissions_api.cc ('k') | chrome/browser/extensions/api/serial/serial_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698