chrome/browser/extensions/image_loading_tracker.cc - Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/image_loading_tracker.cc

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Compile fix Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extensions_quota_service_unittest.cc ('k') | chrome/browser/extensions/mock_extension_special_storage_policy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/image_loading_tracker.cc

diff --git a/chrome/browser/extensions/image_loading_tracker.cc b/chrome/browser/extensions/image_loading_tracker.cc

index 6e804575fdc6f08885495ff5da8d9ee4b13f621a..3bbf4334e5f92bb97ba9281c7123ec73530a5f8e 100644

--- a/chrome/browser/extensions/image_loading_tracker.cc

+++ b/chrome/browser/extensions/image_loading_tracker.cc

@@ -47,8 +47,7 @@ ImageLoadingTracker::PendingLoadInfo::PendingLoadInfo()

pending_count(0) {

}

-ImageLoadingTracker::PendingLoadInfo::~PendingLoadInfo() {

+ImageLoadingTracker::PendingLoadInfo::~PendingLoadInfo() {}

////////////////////////////////////////////////////////////////////////////////

// ImageLoadingTracker::ImageLoader

@@ -161,6 +160,9 @@ class ImageLoadingTracker::ImageLoader

}

private:

+ friend class base::RefCountedThreadSafe<ImageLoader>;

+ ~ImageLoader() {}

// The tracker we are loading the image for. If NULL, it means the tracker is

// no longer interested in the reply.

ImageLoadingTracker* tracker_;