Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: chrome/browser/extensions/extension_preference_api.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_pref_store.cc ('k') | chrome/browser/extensions/extension_protocols.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_preference_api.h
diff --git a/chrome/browser/extensions/extension_preference_api.h b/chrome/browser/extensions/extension_preference_api.h
index 7a4c9f90e58fdad56ec5a21a356aded6bd4504fa..795b0393a556169764bb33ee14496b049a198008 100644
--- a/chrome/browser/extensions/extension_preference_api.h
+++ b/chrome/browser/extensions/extension_preference_api.h
@@ -71,10 +71,9 @@ class PrefTransformerInterface {
// A base class to provide functionality common to the other *PreferenceFunction
// classes.
class PreferenceFunction : public SyncExtensionFunction {
- public:
+ protected:
virtual ~PreferenceFunction();
- protected:
// Given an |extension_pref_key|, provides its |browser_pref_key| from the
// static map in extension_preference.cc. Returns true if the corresponding
// browser pref exists and the extension has the API permission needed to
@@ -86,23 +85,35 @@ class PreferenceFunction : public SyncExtensionFunction {
class GetPreferenceFunction : public PreferenceFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("types.ChromeSetting.get")
+
+ protected:
virtual ~GetPreferenceFunction();
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("types.ChromeSetting.get")
};
class SetPreferenceFunction : public PreferenceFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("types.ChromeSetting.set")
+
+ protected:
virtual ~SetPreferenceFunction();
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("types.ChromeSetting.set")
};
class ClearPreferenceFunction : public PreferenceFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("types.ChromeSetting.clear")
+
+ protected:
virtual ~ClearPreferenceFunction();
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("types.ChromeSetting.clear")
};
#endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_PREFERENCE_API_H__
« no previous file with comments | « chrome/browser/extensions/extension_pref_store.cc ('k') | chrome/browser/extensions/extension_protocols.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698