chrome/browser/extensions/extension_protocols.cc - Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_protocols.cc

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Compile fix Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_preference_api.h ('k') | chrome/browser/extensions/extension_special_storage_policy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_protocols.cc

diff --git a/chrome/browser/extensions/extension_protocols.cc b/chrome/browser/extensions/extension_protocols.cc

index 4b551533b00188845870845d9d44b1bd55a41d48..67e92a7652155cc5d1583b02c983e9da4d56d1f7 100644

--- a/chrome/browser/extensions/extension_protocols.cc

+++ b/chrome/browser/extensions/extension_protocols.cc

@@ -143,6 +143,8 @@ class GeneratedBackgroundPageJob : public net::URLRequestSimpleJob {

}

private:

+ virtual ~GeneratedBackgroundPageJob() {}

scoped_refptr<const Extension> extension_;

net::HttpResponseInfo response_info_;

};

@@ -162,6 +164,9 @@ class URLRequestExtensionJob : public net::URLRequestFileJob {

*info = response_info_;

}

+ private:

+ virtual ~URLRequestExtensionJob() {}

net::HttpResponseInfo response_info_;

};