Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6289)

Unified Diff: chrome/browser/extensions/extension_web_socket_proxy_private_api.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_web_socket_proxy_private_api.h
diff --git a/chrome/browser/extensions/extension_web_socket_proxy_private_api.h b/chrome/browser/extensions/extension_web_socket_proxy_private_api.h
index c104d45be22c8df731158b5b906558e263a74f3e..3f14c99ecfe914d22553ef4224c6f165a60501e2 100644
--- a/chrome/browser/extensions/extension_web_socket_proxy_private_api.h
+++ b/chrome/browser/extensions/extension_web_socket_proxy_private_api.h
@@ -23,9 +23,10 @@ class WebSocketProxyPrivate
: public AsyncExtensionFunction, public content::NotificationObserver {
public:
WebSocketProxyPrivate();
- virtual ~WebSocketProxyPrivate();
protected:
+ virtual ~WebSocketProxyPrivate();
+
// Custom finalization.
virtual void CustomFinalize() = 0;
@@ -77,31 +78,33 @@ class WebSocketProxyPrivate
class WebSocketProxyPrivateGetURLForTCPFunction
: public WebSocketProxyPrivate {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("webSocketProxyPrivate.getURLForTCP")
+
WebSocketProxyPrivateGetURLForTCPFunction();
+
+ protected:
virtual ~WebSocketProxyPrivateGetURLForTCPFunction();
- private:
// ExtensionFunction implementation.
virtual bool RunImpl() OVERRIDE;
// WebSocketProxyPrivate implementation:
virtual void CustomFinalize() OVERRIDE;
-
- DECLARE_EXTENSION_FUNCTION_NAME("webSocketProxyPrivate.getURLForTCP")
};
// Legacy API function for web socket proxy, to be eliminated.
class WebSocketProxyPrivateGetPassportForTCPFunction
: public WebSocketProxyPrivate {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("webSocketProxyPrivate.getPassportForTCP")
+
WebSocketProxyPrivateGetPassportForTCPFunction();
+
+ protected:
virtual ~WebSocketProxyPrivateGetPassportForTCPFunction();
- private:
// WebSocketProxyPrivate implementation:
virtual void CustomFinalize() OVERRIDE;
-
- DECLARE_EXTENSION_FUNCTION_NAME("webSocketProxyPrivate.getPassportForTCP")
};
#endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_WEB_SOCKET_PROXY_PRIVATE_API_H_
« no previous file with comments | « chrome/browser/extensions/extension_test_api.h ('k') | chrome/browser/extensions/extension_webstore_private_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698