Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: chrome/browser/extensions/webstore_installer.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/webstore_installer.h
diff --git a/chrome/browser/extensions/webstore_installer.h b/chrome/browser/extensions/webstore_installer.h
index 718599e9bd9bc65db9e323f4c3620185934b4f82..b1e7b5d55867b07043dffb0b15686a6ee55fbe07 100644
--- a/chrome/browser/extensions/webstore_installer.h
+++ b/chrome/browser/extensions/webstore_installer.h
@@ -89,7 +89,6 @@ class WebstoreInstaller : public content::NotificationObserver,
const std::string& id,
scoped_ptr<Approval> approval,
int flags);
- virtual ~WebstoreInstaller();
// Starts downloading and installing the extension.
void Start();
@@ -104,6 +103,9 @@ class WebstoreInstaller : public content::NotificationObserver,
static void SetDownloadDirectoryForTests(FilePath* directory);
private:
+ friend class base::RefCounted<WebstoreInstaller>;
+ virtual ~WebstoreInstaller();
+
// DownloadManager::DownloadUrl callback.
void OnDownloadStarted(content::DownloadId id, net::Error error);
« no previous file with comments | « chrome/browser/extensions/webstore_inline_installer.cc ('k') | chrome/browser/extensions/webstore_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698