Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7608)

Unified Diff: chrome/browser/extensions/extensions_quota_service_unittest.cc

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extensions_quota_service_unittest.cc
diff --git a/chrome/browser/extensions/extensions_quota_service_unittest.cc b/chrome/browser/extensions/extensions_quota_service_unittest.cc
index c13b4f022a6fd9351320ba92fef7d9302b4a9782..ebdcfc3cd0324790c418d9b330cc08a9f1234af7 100644
--- a/chrome/browser/extensions/extensions_quota_service_unittest.cc
+++ b/chrome/browser/extensions/extensions_quota_service_unittest.cc
@@ -56,6 +56,7 @@ class MockMapper : public QuotaLimitHeuristic::BucketMapper {
class MockFunction : public ExtensionFunction {
public:
explicit MockFunction(const std::string& name) { set_name(name); }
+
virtual void SetArgs(const ListValue* args) OVERRIDE {}
virtual const std::string GetError() OVERRIDE { return std::string(); }
virtual void SetError(const std::string& error) OVERRIDE {}
@@ -63,6 +64,9 @@ class MockFunction : public ExtensionFunction {
virtual void Destruct() const OVERRIDE { delete this; }
virtual bool RunImpl() OVERRIDE { return true; }
virtual void SendResponse(bool) OVERRIDE { }
+
+ protected:
+ virtual ~MockFunction() {}
};
class TimedLimitMockFunction : public MockFunction {
@@ -73,6 +77,9 @@ class TimedLimitMockFunction : public MockFunction {
QuotaLimitHeuristics* heuristics) const {
heuristics->push_back(new TimedLimit(k2PerMinute, new Mapper()));
}
+
+ private:
+ virtual ~TimedLimitMockFunction() {}
};
class ChainedLimitsMockFunction : public MockFunction {
@@ -87,6 +94,9 @@ class ChainedLimitsMockFunction : public MockFunction {
// No more than 20 per hour.
heuristics->push_back(new TimedLimit(k20PerHour, new Mapper()));
}
+
+ private:
+ virtual ~ChainedLimitsMockFunction() {}
};
class FrozenMockFunction : public MockFunction {
@@ -96,6 +106,9 @@ class FrozenMockFunction : public MockFunction {
QuotaLimitHeuristics* heuristics) const {
heuristics->push_back(new TimedLimit(kFrozenConfig, new Mapper()));
}
+
+ private:
+ virtual ~FrozenMockFunction() {}
};
} // namespace
« no previous file with comments | « chrome/browser/extensions/extension_webstore_private_api.h ('k') | chrome/browser/extensions/image_loading_tracker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698