RefCounted types should not have public destructors, chrome/browser/extensions

chrome/browser/extensions/webstore_installer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/webstore_installer.h"
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
@@ skipping 101 matching lines @@
   int uniquifier = file_util::GetUniquePathNumber(file, FILE_PATH_LITERAL(""));
   if (uniquifier > 0)
     file = file.InsertBeforeExtensionASCII(StringPrintf(" (%d)", uniquifier));
 
   BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
                           base::Bind(callback, file));
 }
 
 }  // namespace
 
+WebstoreInstaller::Approval::Approval()
+    : profile(NULL),
+      use_app_installed_bubble(false),
+      skip_post_install_ui(false) {
+}
+
+WebstoreInstaller::Approval::~Approval() {}
+
 const WebstoreInstaller::Approval* WebstoreInstaller::GetAssociatedApproval(
     const DownloadItem& download) {
   return static_cast<const Approval*>(download.GetExternalData(kApprovalKey));
 }
 
-WebstoreInstaller::Approval::Approval()
-    : profile(NULL),
-      use_app_installed_bubble(false),
-      skip_post_install_ui(false) {}
-WebstoreInstaller::Approval::~Approval() {}
-
 WebstoreInstaller::WebstoreInstaller(Profile* profile,
                                      Delegate* delegate,
                                      NavigationController* controller,
                                      const std::string& id,
                                      scoped_ptr<Approval> approval,
                                      int flags)
     : profile_(profile),
       delegate_(delegate),
       controller_(controller),
       id_(id),
       download_item_(NULL),
       flags_(flags),
       approval_(approval.release()) {
   download_url_ = GetWebstoreInstallURL(id, flags & FLAG_INLINE_INSTALL ?
       kInlineInstallSource : kDefaultInstallSource);
 
   registrar_.Add(this, chrome::NOTIFICATION_CRX_INSTALLER_DONE,
                  content::NotificationService::AllSources());
   registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_INSTALLED,
                  content::Source<Profile>(profile->GetOriginalProfile()));
   registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_INSTALL_ERROR,
                  content::Source<CrxInstaller>(NULL));
 }
 
-WebstoreInstaller::~WebstoreInstaller() {
-  if (download_item_) {
-    download_item_->RemoveObserver(this);
-    download_item_ = NULL;
-  }
-}
-
 void WebstoreInstaller::Start() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   AddRef();  // Balanced in ReportSuccess and ReportFailure.
 
   if (!Extension::IdIsValid(id_)) {
     ReportFailure(kInvalidIdError);
     return;
   }
 
   FilePath download_path = DownloadPrefs::FromDownloadManager(
@@ skipping 48 matching lines @@
 
     default:
       NOTREACHED();
   }
 }
 
 void WebstoreInstaller::SetDownloadDirectoryForTests(FilePath* directory) {
   g_download_directory_for_tests = directory;
 }
 
+WebstoreInstaller::~WebstoreInstaller() {
+  if (download_item_) {
+    download_item_->RemoveObserver(this);
+    download_item_ = NULL;
+  }
+}
+
 void WebstoreInstaller::OnDownloadStarted(DownloadId id, net::Error error) {
   if (error != net::OK) {
     ReportFailure(net::ErrorToString(error));
     return;
   }
 
   CHECK(id.IsValid());
 
   content::DownloadManager* download_manager = profile_->GetDownloadManager();
   download_item_ = download_manager->GetActiveDownloadItem(id.local());
@@ skipping 72 matching lines @@
 }
 
 void WebstoreInstaller::ReportSuccess() {
   if (delegate_) {
     delegate_->OnExtensionInstallSuccess(id_);
     delegate_ = NULL;
   }
 
   Release();  // Balanced in Start().
 }