RefCounted types should not have public destructors, chrome/browser/extensions

chrome/browser/extensions/api/socket/socket_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_SOCKET_SOCKET_API_H_
 #define CHROME_BROWSER_EXTENSIONS_API_SOCKET_SOCKET_API_H_
 #pragma once
 
 #include "base/memory/ref_counted.h"
 #include "chrome/browser/extensions/api/api_function.h"
@@ skipping 12 matching lines @@
 extern const char kUdpSocketType[];
 
 // Many of these socket functions are synchronous in the sense that
 // they don't involve blocking operations, but we've made them all
 // AsyncExtensionFunctions because the underlying UDPClientSocket
 // library wants all operations to happen on the same thread as the
 // one that created the socket. Too bad.
 
 class SocketCreateFunction : public AsyncIOAPIFunction {
  public:
+  DECLARE_EXTENSION_FUNCTION_NAME("experimental.socket.create")
+
   SocketCreateFunction();
 
  protected:
+  virtual ~SocketCreateFunction();
+
+  // AsyncIOAPIFunction:
   virtual bool Prepare() OVERRIDE;
   virtual void Work() OVERRIDE;
   virtual bool Respond() OVERRIDE;
 
  private:
   enum SocketType {
     kSocketTypeInvalid = -1,
     kSocketTypeTCP,
     kSocketTypeUDP
   };
 
   SocketType socket_type_;
   int src_id_;
   APIResourceEventNotifier* event_notifier_;
-
-  DECLARE_EXTENSION_FUNCTION_NAME("experimental.socket.create")
 };
 
 class SocketDestroyFunction : public AsyncIOAPIFunction {
+ public:
+  DECLARE_EXTENSION_FUNCTION_NAME("experimental.socket.destroy")
+
  protected:
+  virtual ~SocketDestroyFunction() {}
+
+  // AsyncIOAPIFunction:
   virtual bool Prepare() OVERRIDE;
   virtual void Work() OVERRIDE;
   virtual bool Respond() OVERRIDE;
 
  private:
   int socket_id_;
-
-  DECLARE_EXTENSION_FUNCTION_NAME("experimental.socket.destroy")
 };
 
 class SocketConnectFunction : public AsyncIOAPIFunction {
+ public:
+  DECLARE_EXTENSION_FUNCTION_NAME("experimental.socket.connect")
+
  protected:
+  virtual ~SocketConnectFunction() {}
+
+  // AsyncIOAPIFunction:
   virtual bool Prepare() OVERRIDE;
   virtual void Work() OVERRIDE;
   virtual bool Respond() OVERRIDE;
 
  private:
   int socket_id_;
   std::string address_;
   int port_;
-
-  DECLARE_EXTENSION_FUNCTION_NAME("experimental.socket.connect")
 };
 
 class SocketDisconnectFunction : public AsyncIOAPIFunction {
+ public:
+  DECLARE_EXTENSION_FUNCTION_NAME("experimental.socket.disconnect")
+
  protected:
+  virtual ~SocketDisconnectFunction() {}
+
+  // AsyncIOAPIFunction:
   virtual bool Prepare() OVERRIDE;
   virtual void Work() OVERRIDE;
   virtual bool Respond() OVERRIDE;
 
  private:
   int socket_id_;
-
-  DECLARE_EXTENSION_FUNCTION_NAME("experimental.socket.disconnect")
 };
 
 class SocketBindFunction : public AsyncIOAPIFunction {
  protected:
   virtual bool Prepare() OVERRIDE;
   virtual void Work() OVERRIDE;
   virtual bool Respond() OVERRIDE;
 
  private:
   int socket_id_;
   std::string address_;
   int port_;
 
   DECLARE_EXTENSION_FUNCTION_NAME("experimental.socket.bind")
 };
 
 class SocketReadFunction : public AsyncIOAPIFunction {
+ public:
+  DECLARE_EXTENSION_FUNCTION_NAME("experimental.socket.read")
+
  protected:
+  virtual ~SocketReadFunction() {}
+
+  // AsyncIOAPIFunction:
   virtual bool Prepare() OVERRIDE;
   virtual void Work() OVERRIDE;
   virtual bool Respond() OVERRIDE;
 
  private:
   int socket_id_;
-
-  DECLARE_EXTENSION_FUNCTION_NAME("experimental.socket.read")
 };
 
 class SocketWriteFunction : public AsyncIOAPIFunction {
  public:
+  DECLARE_EXTENSION_FUNCTION_NAME("experimental.socket.write")
+
   SocketWriteFunction();
+
+ protected:
   virtual ~SocketWriteFunction();
 
- protected:
+  // AsyncIOAPIFunction:
   virtual bool Prepare() OVERRIDE;
   virtual void Work() OVERRIDE;
   virtual bool Respond() OVERRIDE;
 
  private:
   int socket_id_;
   scoped_refptr<net::IOBufferWithSize> io_buffer_;
-
-  DECLARE_EXTENSION_FUNCTION_NAME("experimental.socket.write")
 };
 
 class SocketRecvFromFunction : public AsyncIOAPIFunction {
+ public:
+  DECLARE_EXTENSION_FUNCTION_NAME("experimental.socket.recvFrom")
+
  protected:
+  virtual ~SocketRecvFromFunction();
+
+  // AsyncIOAPIFunction
   virtual bool Prepare() OVERRIDE;
   virtual void Work() OVERRIDE;
   virtual bool Respond() OVERRIDE;
 
  private:
   int socket_id_;
   net::IPEndPoint address_;
-
-  DECLARE_EXTENSION_FUNCTION_NAME("experimental.socket.recvFrom")
 };
 
 class SocketSendToFunction : public AsyncIOAPIFunction {
-  public:
-   SocketSendToFunction();
-   virtual ~SocketSendToFunction();
+ public:
+  DECLARE_EXTENSION_FUNCTION_NAME("experimental.socket.sendTo")
 
-  protected:
+  SocketSendToFunction();
+
+ protected:
+  virtual ~SocketSendToFunction();
+
+  // AsyncIOAPIFunction:
   virtual bool Prepare() OVERRIDE;
   virtual void Work() OVERRIDE;
   virtual bool Respond() OVERRIDE;
 
  private:
   int socket_id_;
   scoped_refptr<net::IOBufferWithSize> io_buffer_;
   std::string address_;
   int port_;
-
-  DECLARE_EXTENSION_FUNCTION_NAME("experimental.socket.sendTo")
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_SOCKET_SOCKET_API_H_